Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enhance logging in WebSocketJwtAuthInterceptor to enable root cause analysis if connections are being rejected #79

Merged
merged 4 commits into from
Sep 15, 2024

Conversation

rbeauchamp
Copy link
Contributor

PR Classification

Enhancement: Improved logging, build configuration, and packaging.

PR Summary

This PR enhances logging in the WebSocket JWT authentication process, updates build configuration, and improves packaging.

  • WebSocketJwtAuthInterceptor.cs: Added detailed logging for WebSocket connection and JWT validation, including new method LogTokenValidationParameters and exception handling.
  • release-drafter.yml: Updated with new categories and labels for build, CI, and revert changes.
  • RxDBDotNet.csproj: Added PackageReadmeFile property and included README.md in the package.

@github-actions github-actions bot added the chore Miscellaneous updates, e.g. modifying .gitignore label Sep 15, 2024
@rbeauchamp rbeauchamp self-assigned this Sep 15, 2024
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (eb27d1b) to head (fbe3f09).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          220       241   +21     
  Branches        12        14    +2     
=========================================
+ Hits           220       241   +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbeauchamp rbeauchamp merged commit 9360dd6 into main Sep 15, 2024
6 checks passed
@rbeauchamp rbeauchamp deleted the enahnce-logging-for-websocket-interceptor branch September 15, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Miscellaneous updates, e.g. modifying .gitignore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant