[Bugfix] CacheLoginThrottleService->isThrottled

[freezy-sk]

When login fails on too many login attempts, it's not possible to check it because isThrottled() is passing different identity into countThrottle() method.
Now it will be the same and it should fix #387 and #392

[coveralls]

Coverage decreased (-0.97%) when pulling 36271f2 on freezy-sk:bugfix/isThrottled into bdfbcff on Zizaco:master.

[ghost]

@freezy-sk I think you should still do the serialize in case username and email don't exist.

    public function isThrottled($identity)
    {
        $identity = $this->parseIdentity($identity);

        // Retuns the current count
        $count = $this->countThrottle($identity, 0);

    }
    protected function countThrottle($identityString, $increments = 1)
    {
        $count = $this->app['cache']
            ->get('login_throttling:'.md5($identityString), 0);

       ....
    }

md5($identityString)

string md5 ( string $str [, bool $raw_output = false ] )

[freezy-sk]

@WPPD yes you're right but the best would be using same function for isThrottled and loginAttempt but it needs bigger refactoring

[Zizaco]

Can you please remove .idea from .gitignore.
It's better to put this into your global git config instead.

[Zizaco]

Thanks. But can you fix the gitignore first?

[coveralls]

Coverage decreased (-0.96%) when pulling 1644f09 on freezy-sk:bugfix/isThrottled into bdfbcff on Zizaco:master.

[freezy-sk]

@Zizaco It's removed right now. I have it in my global gitignore but it's my (bad)habit to add it also to project just to be sure that other developers don't commit their .idea if they don't have it globally ignored.

[Zizaco]

😄