Entrust permission caching #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 19, 2015 16:28
* Cache what permissions a role has
…Facade setup to a setUp() method.
|
Most platforms passed the TravisCI check; PHP 5.4 failed because of some composer dependencies. What should be done about 5.4? |
|
We can drop 5.4. Can you change the travis requirements? |
|
Done, and the Composer php requirement too. All tests are passing. |
|
Awesome. Looks good.Thanks for the quick fix! |
andrewelkins
added a commit
that referenced
this pull request
Nov 20, 2015
Entrust permission caching. Thanks @scottconnerly
|
Hi Scott, unfortunately one of my applications runs in Laravel 4 and it does really a lot of permission checks per request. As I'm not really familiar yet with writing traits, how would you estimate the effort of rewriting this caching feature into the L4 branch ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #107