Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for tar.gz tar.bz archives #4

Closed
tglman opened this issue Jun 11, 2017 · 2 comments
Closed

Support for tar.gz tar.bz archives #4

tglman opened this issue Jun 11, 2017 · 2 comments

Comments

@tglman
Copy link

tglman commented Jun 11, 2017

Hi,

Would be cool to add the support of stripping dates also from tar.gz tar.bz archives that are often generated in maven build with assembly plugin.

This can be easily achieved building a Stripper using TarArchiveEntry

Bye

@Zlika
Copy link
Owner

Zlika commented Jun 12, 2017

Hi,

That's a good idea, but I don't have time to work on it right now, so you can propose a PR if you want.

@tglman
Copy link
Author

tglman commented Jun 19, 2017

hi @Zlika,

What is the code formatter did you use ? I'm using eclipse, and I'm a step ahead on the PR, but I would prefer to use your code formatter for coherence, as well what are the field that should be stripped in the tar ?

some hint on the WIP https://gist.github.com/tglman/520e6c04f407ef07d8a3a6b290d3c20d

Regards

@Zlika Zlika closed this as completed in #14 Feb 15, 2018
Zlika pushed a commit that referenced this issue Feb 15, 2018
Support for tar.gz and tar.bz archives.

* Implemented support for tar.gz and tar.bz archives

* removed maven specific stripper from tar stripper, removed no need anymore abstract class, applied codestyle

* support for tar archives passes test and code quality checks

* thorough check on stripped tar archive

* integration tests for tar archives stripping are passing

* refactoring to make checkstyle happy

* uid,gid=0 also fixed unit test for tar files

* integration test for assembly plugin unpack=false

* dropped Consumer interface

* uncomment the user.name properties in the IT for tar archives

* add IT for tar.gz and tar.bz2, drop IT for tar-packed

* reverted formatting changes

* tar: keep packed version

* unify tar IT in one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants