improve getting airline name #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as the table with airline information is only available on dashboard the name should be should be taken from somewhere else, the drop down selection menu the airline code should no longer be used ZoeBijl#18
switch to relevant functions in AES helper class added some error handling
further cleaning up of airlinename functions added documentation of existing airline identification functions
further cleanup of airlinename/servername functions moving getAirlineId() to AES class
|
Thank you for this! I’ll try to do a full review tomorrow |
as long as jQuery is there used updated one
This reverts commit 9165ca3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: as the table with airline information is only available on dashboard the name should be should be taken from somewhere else, the drop down selection menu the airline code should no longer be used
#18