Modified stencil #31
Merged
Modified stencil #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoeLeibowitz
force-pushed
the
modifed_stencil
branch
from
811bdfa to
95bda78
Compare
EdCaunt
reviewed
Oct 18, 2024
mloubout
reviewed
Oct 18, 2024
| )), | ||
| ('Eq(g1, f1.laplace).evaluate', 'f1', | ||
| ( | ||
| '-g1(x, y)', |
Collaborator
There was a problem hiding this comment.
Not great to have the - signe on both side, can it be avoided?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to ensure that pre-evaluated equations can be passed to
PETScSolve, allowing support for modified stencils to handle certain boundary conditions, such as free-surface boundary conditions.