Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Strings from the flat absy #131

Merged
merged 17 commits into from
Oct 5, 2018

Conversation

Schaeff
Copy link
Member

@Schaeff Schaeff commented Sep 24, 2018

The current core of the compiler uses string substitution to flatten constructs. This has a considerable cost especially during function call resolution.

Introduce FlatVariable which is cheap and Copy, and keep track of bindings between non-flattened variable names and FlatVariables in a bijection table.

Other changes introduced:

  • Get rid of substring-based witness generation (x_b5 being interpreted as the 6th bit or x at run time) and instead use explicit Directives
  • Remove loops from substitution calls: we only need to know the latest FlatVariable for a given Variable, not each intermediate one

To merge after #130

@Schaeff
Copy link
Member Author

Schaeff commented Oct 4, 2018

jenkins-test

@JacobEberhardt JacobEberhardt merged commit 5f68001 into Zokrates:develop Oct 5, 2018
@Schaeff Schaeff deleted the string-free-flat-absy branch October 5, 2018 08:55
@Schaeff Schaeff mentioned this pull request Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants