Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to pest parser #306

Merged
merged 32 commits into from
Jun 7, 2019
Merged

Switch to pest parser #306

merged 32 commits into from
Jun 7, 2019

Conversation

Schaeff
Copy link
Member

@Schaeff Schaeff commented Mar 20, 2019 •
edited
Loading

Todo

  • Review and merge PRs in ast and parser
  • Decide on project structure: multi repo?
  • Carry span information to absy (currently mocked)
  • Add error management to from_ast

@Schaeff Schaeff changed the base branch from master to develop March 20, 2019 23:03
This was referenced Apr 16, 2019
Closed
Closed
Closed
@Schaeff Schaeff mentioned this pull request May 6, 2019
Closed
@Schaeff Schaeff changed the title [WIP] Switch to pest parser Switch to pest parser Jun 3, 2019
JacobEberhardt
JacobEberhardt previously approved these changes Jun 7, 2019
View reviewed changes
zokrates_core/src/absy/from_ast.rs
let private = param
.visibility
.map(|v| match v {
pest::Visibility::Private(_) => true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it surprising that the visibilities are represented as structs in the zokrates_pest_ast. Since it's converted to bool here, it's fine as isolated from core.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, this is done because we don't want to parse this ourselves, so creating a rule and an associated struct works.

zokrates_core/src/absy/from_ast.rs Show resolved Hide resolved
@JacobEberhardt JacobEberhardt mentioned this pull request Jun 7, 2019
Open
JacobEberhardt
JacobEberhardt approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@JacobEberhardt JacobEberhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Issues created for open points.

@JacobEberhardt JacobEberhardt merged commit 14a579f into develop Jun 7, 2019
@JacobEberhardt JacobEberhardt deleted the pest-parser branch June 7, 2019 16:27
@Schaeff Schaeff mentioned this pull request Jun 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobEberhardt JacobEberhardt JacobEberhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Schaeff @JacobEberhardt