Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce zokrates_test crate #474

Merged
merged 11 commits into from
Sep 19, 2019
Merged

Introduce zokrates_test crate #474

merged 11 commits into from
Sep 19, 2019

Conversation

Schaeff
Copy link
Member

@Schaeff Schaeff commented Sep 17, 2019

No description provided.

@JacobEberhardt
Copy link
Member

We should replace the benchdirectory with a more accurate name, since there is no profiling taking place.

@JacobEberhardt
Copy link
Member

JacobEberhardt commented Sep 18, 2019 •
edited
Loading

Looks good, but doc needs to be updated.
zokrates_book/src/reference/Testing.md

@JacobEberhardt
Copy link
Member

Edited the documentation. Would appreciate a quick review.

JacobEberhardt
JacobEberhardt approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@JacobEberhardt JacobEberhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
We should further improve testing over time and move integration testing out of zokrates_cli into the zokrates_testcrate.
This is another PR, though.

@JacobEberhardt JacobEberhardt merged commit 7486649 into develop Sep 19, 2019
@JacobEberhardt JacobEberhardt deleted the zokrates-test-crate branch September 19, 2019 16:06
@Schaeff Schaeff mentioned this pull request Oct 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobEberhardt JacobEberhardt JacobEberhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Schaeff @JacobEberhardt