Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't be used on Arbitrum and Optimism #7

Closed
PaulRBerg opened this issue Oct 15, 2021 · 7 comments
Closed

Can't be used on Arbitrum and Optimism #7

PaulRBerg opened this issue Oct 15, 2021 · 7 comments

Comments

@PaulRBerg
Copy link

PaulRBerg commented Oct 15, 2021

My understanding is that the deployer address has been "retrodicted" with Nick's method, and the chosen gas price and the gas limit influence what value the deployer address has.

If that is correct, this deployment proxy cannot be used on optimistic rollup chains like Arbitrum or Optimism, because of the way gas is calculated there. E.g. a basic aETH transfer costs ~700k.

@MicahZoltu
Copy link
Member

The gas limit for the transaction was intentionally chosen to be "significantly higher than necessary" to ensure that moderate changes to gas pricing shouldn't affect the ability to deploy this in the future. However, very significant gas pricing changes may be too much for the excessive limit to handle.

@gakonst
Copy link

gakonst commented May 17, 2022

FYI the contract has been deployed via admin functionality on Arbitrum at the same address

@PaulRBerg
Copy link
Author

@gakonst oh, that's so cool. Do you know anyone who has the ability to set the deployment proxy at the same address on Optimism?

@tynes
Copy link

tynes commented May 18, 2022

There are some existing deterministic deployment proxies on Optimism, see ethereum-optimism/optimism#1883

EIP-1820: https://optimistic.etherscan.io/address/0x1820a4b7618bde71dce8cdc73aab6c95905fad24#code
EIP-2470: https://optimistic.etherscan.io/address/0xce0042b868300000d44a59004da54a005ffdcf9f#code

You should be able to deploy this proxy to Optimism as well

@smartcontracts
Copy link

smartcontracts commented May 18, 2022

Should be deployable to Optimism, can use standard deploy flow

Edit: I deployed it https://optimistic.etherscan.io/address/0x7A0D94F55792C434d74a40883C6ed8545E406D12#code

@smartcontracts
Copy link

For future reference, "nicks method" deployments will always work on Optimism, sometimes just need to give the account a little extra ETH to pay for fees

@PaulRBerg
Copy link
Author

Thanks @smartcontracts for deploying Micah's deployment proxy on Optimism!

For future reference, "nicks method" deployments will always work on Optimism, sometimes just need to give the account a little extra ETH to pay for fees

Gotcha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants