Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy ERC-1820 to Kovan and Mainnet #1883

Closed
d10r opened this issue Dec 7, 2021 · 9 comments
Closed

Deploy ERC-1820 to Kovan and Mainnet #1883

d10r opened this issue Dec 7, 2021 · 9 comments
Labels
C-bug Category: bugs S-confirmed Status: A confirmed bug

Comments

@d10r
Copy link

d10r commented Dec 7, 2021

TL;DR: please execute

web3.eth.sendRawTransaction("0xf90a388085174876e800830c35008080b909e5608060405234801561001057600080fd5b506109c5806100206000396000f3fe608060405234801561001057600080fd5b50600436106100a5576000357c010000000000000000000000000000000000000000000000000000000090048063a41e7d5111610078578063a41e7d51146101d4578063aabbb8ca1461020a578063b705676514610236578063f712f3e814610280576100a5565b806329965a1d146100aa5780633d584063146100e25780635df8122f1461012457806365ba36c114610152575b600080fd5b6100e0600480360360608110156100c057600080fd5b50600160a060020a038135811691602081013591604090910135166102b6565b005b610108600480360360208110156100f857600080fd5b5035600160a060020a0316610570565b60408051600160a060020a039092168252519081900360200190f35b6100e06004803603604081101561013a57600080fd5b50600160a060020a03813581169160200135166105bc565b6101c26004803603602081101561016857600080fd5b81019060208101813564010000000081111561018357600080fd5b82018360208201111561019557600080fd5b803590602001918460018302840111640100000000831117156101b757600080fd5b5090925090506106b3565b60408051918252519081900360200190f35b6100e0600480360360408110156101ea57600080fd5b508035600160a060020a03169060200135600160e060020a0319166106ee565b6101086004803603604081101561022057600080fd5b50600160a060020a038135169060200135610778565b61026c6004803603604081101561024c57600080fd5b508035600160a060020a03169060200135600160e060020a0319166107ef565b604080519115158252519081900360200190f35b61026c6004803603604081101561029657600080fd5b508035600160a060020a03169060200135600160e060020a0319166108aa565b6000600160a060020a038416156102cd57836102cf565b335b9050336102db82610570565b600160a060020a031614610339576040805160e560020a62461bcd02815260206004820152600f60248201527f4e6f7420746865206d616e616765720000000000000000000000000000000000604482015290519081900360640190fd5b6103428361092a565b15610397576040805160e560020a62461bcd02815260206004820152601a60248201527f4d757374206e6f7420626520616e204552433136352068617368000000000000604482015290519081900360640190fd5b600160a060020a038216158015906103b85750600160a060020a0382163314155b156104ff5760405160200180807f455243313832305f4143434550545f4d4147494300000000000000000000000081525060140190506040516020818303038152906040528051906020012082600160a060020a031663249cb3fa85846040518363ffffffff167c01000000000000000000000000000000000000000000000000000000000281526004018083815260200182600160a060020a0316600160a060020a031681526020019250505060206040518083038186803b15801561047e57600080fd5b505afa158015610492573d6000803e3d6000fd5b505050506040513d60208110156104a857600080fd5b5051146104ff576040805160e560020a62461bcd02815260206004820181905260248201527f446f6573206e6f7420696d706c656d656e742074686520696e74657266616365604482015290519081900360640190fd5b600160a060020a03818116600081815260208181526040808320888452909152808220805473ffffffffffffffffffffffffffffffffffffffff19169487169485179055518692917f93baa6efbd2244243bfee6ce4cfdd1d04fc4c0e9a786abd3a41313bd352db15391a450505050565b600160a060020a03818116600090815260016020526040812054909116151561059a5750806105b7565b50600160a060020a03808216600090815260016020526040902054165b919050565b336105c683610570565b600160a060020a031614610624576040805160e560020a62461bcd02815260206004820152600f60248201527f4e6f7420746865206d616e616765720000000000000000000000000000000000604482015290519081900360640190fd5b81600160a060020a031681600160a060020a0316146106435780610646565b60005b600160a060020a03838116600081815260016020526040808220805473ffffffffffffffffffffffffffffffffffffffff19169585169590951790945592519184169290917f605c2dbf762e5f7d60a546d42e7205dcb1b011ebc62a61736a57c9089d3a43509190a35050565b600082826040516020018083838082843780830192505050925050506040516020818303038152906040528051906020012090505b92915050565b6106f882826107ef565b610703576000610705565b815b600160a060020a03928316600081815260208181526040808320600160e060020a031996909616808452958252808320805473ffffffffffffffffffffffffffffffffffffffff19169590971694909417909555908152600284528181209281529190925220805460ff19166001179055565b600080600160a060020a038416156107905783610792565b335b905061079d8361092a565b156107c357826107ad82826108aa565b6107b85760006107ba565b815b925050506106e8565b600160a060020a0390811660009081526020818152604080832086845290915290205416905092915050565b6000808061081d857f01ffc9a70000000000000000000000000000000000000000000000000000000061094c565b909250905081158061082d575080155b1561083d576000925050506106e8565b61084f85600160e060020a031961094c565b909250905081158061086057508015155b15610870576000925050506106e8565b61087a858561094c565b909250905060018214801561088f5750806001145b1561089f576001925050506106e8565b506000949350505050565b600160a060020a0382166000908152600260209081526040808320600160e060020a03198516845290915281205460ff1615156108f2576108eb83836107ef565b90506106e8565b50600160a060020a03808316600081815260208181526040808320600160e060020a0319871684529091529020549091161492915050565b7bffffffffffffffffffffffffffffffffffffffffffffffffffffffff161590565b6040517f01ffc9a7000000000000000000000000000000000000000000000000000000008082526004820183905260009182919060208160248189617530fa90519096909550935050505056fea165627a7a72305820377f4a2d4301ede9949f163f319021a6e9c687c292a5e2b2c4734c126b524e6c00291ba01820182018201820182018201820182018201820182018201820182018201820a01820182018201820182018201820182018201820182018201820182018201820")

Context:
This deploys ERC-1820, the lack of which has been blocking me for weeks now.
ERC-1820 is a registry contract widely used on mainnet and other networks. A range of other EIPs - e.g. ERC-777 - depend on it.
It was a predeployed contract on OVM 1.0.

On OVM 2.0, it's not predeployed anymore, because - in theory - it can now be deployed at runtime.
In practice, I couldn't deploy it myself because
a) the sequencer blocked unprotected transactions. This is now fixed with #1720
b) the sequencer rejects the tx above with Error: gas price too high: 100000000000 wei, use at most tx.gasPrice = 10000 wei

Since I don't have an issue with that limitation, but just need ERC-1820, please somebody from the team deploy it.

@smartcontracts
Copy link
Contributor

Yep, working on it!

@smartcontracts
Copy link
Contributor

cc @tynes @mslipper we're going to have to get rid of the upper bound allowable gas price for this to work. I don't really know why that upper bound exists in the first place, so I don't see the problem in doing so. I believe this upper bound is only on the Sequencer side so should be an easy upgrade to execute.

@smartcontracts smartcontracts added C-bug Category: bugs C-feature-request S-confirmed Status: A confirmed bug labels Dec 7, 2021
@tynes
Copy link
Contributor

tynes commented Dec 7, 2021

The bound exists to prevent users from accidentally sending transactions with too high of a fee. We can remove it if its causing other issues.

@smartcontracts
Copy link
Contributor

Should be deployed to Kovan by EOD today. Mainnet tomorrow, I think.

@smartcontracts
Copy link
Contributor

smartcontracts commented Dec 7, 2021

@smartcontracts
Copy link
Contributor

EIP-2470 has now been deployed to Kovan: https://kovan-optimistic.etherscan.io/address/0xce0042b868300000d44a59004da54a005ffdcf9f

@smartcontracts smartcontracts changed the title Somebody deploy ERC-1820 please Deploy ERC-1820 to Kovan and Mainnet Dec 7, 2021
@d10r
Copy link
Author

d10r commented Dec 8, 2021

thanks!
I'll see if we can sponsor deployment on OP mainnet.

@smartcontracts
Copy link
Contributor

smartcontracts commented Dec 10, 2021

I've funded both deployer accounts, now just waiting for the addresses to be whitelisted so I can execute the transactions on mainnet. Hopefully that'll be done by the end of the day today.

@smartcontracts
Copy link
Contributor

EIP-1820 and EIP-2470 have now been deployed to OE mainnet! Closing this issue.

EIP-1820: https://optimistic.etherscan.io/address/0x1820a4b7618bde71dce8cdc73aab6c95905fad24#code
EIP-2470: https://optimistic.etherscan.io/address/0xce0042b868300000d44a59004da54a005ffdcf9f#code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bugs S-confirmed Status: A confirmed bug
Projects
None yet
Development

No branches or pull requests

3 participants