Add factory method to parse multisig address in genesis #219

ziscky · 2024-07-16T23:45:48Z

https://app.clickup.com/t/2469579/8694vhmqk

This is the current output ( in JSON ) of the generated multisig data for the addresses in the genesis_balances.

Reference: lotus msig inspect f0121 implemented in https://github.com/filecoin-project/lotus/blob/2714a84248095f877f52ce20e737d9c8843a352a/cli/multisig.go#L188

TODO:

How to generate the ID without the TxCID ?
Should we leave the MultiSigInfo.TxCID empty ?
What should be the default MultiSigInfo.Signer when there are multiple signers ?

[
  {
    "id": "",
    "multisig_address": "f090",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":1,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\"],\"StartEpoch\":0,\"UnlockDuration\":0}",
    "signer": "f090"
  },
  {
    "id": "",
    "multisig_address": "f0117",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":3,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\",\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\",\"f1ovvm6oilbdsvbw27jhil3pcywrjuwiv5uzagq6i\",\"f1cadxk4yywa7hfaiz3rs23t3wmyn7cjcdy5rtm4q\",\"f3udf6vhs3xj7broosspzwjpbldee77qnrtzytpqrz2h6lfnx7sp3xwe3nn6lpg5eylpp3f7nmrqclt4zmd42a\",\"f3thj7rtskyyvqw2i4v6xg6x32rgaf5pqpkgzcdreuapfl4revnez62geu4ens2aarapuppsmok5af3rzmtgua\",\"f1t3atfumgpjhismj7pp3x63gpevxrsz4y2hgc4ci\"],\"StartEpoch\":0,\"UnlockDuration\":6307200}",
    "signer": "f0117"
  },
  {
    "id": "",
    "multisig_address": "f0121",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":3,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\",\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\",\"f1ovvm6oilbdsvbw27jhil3pcywrjuwiv5uzagq6i\",\"f1cadxk4yywa7hfaiz3rs23t3wmyn7cjcdy5rtm4q\",\"f3udf6vhs3xj7broosspzwjpbldee77qnrtzytpqrz2h6lfnx7sp3xwe3nn6lpg5eylpp3f7nmrqclt4zmd42a\",\"f3thj7rtskyyvqw2i4v6xg6x32rgaf5pqpkgzcdreuapfl4revnez62geu4ens2aarapuppsmok5af3rzmtgua\",\"f1t3atfumgpjhismj7pp3x63gpevxrsz4y2hgc4ci\"],\"StartEpoch\":0,\"UnlockDuration\":6307200}",
    "signer": "f0121"
  },
  {
    "id": "",
    "multisig_address": "f0118",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":3,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\",\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\",\"f1ovvm6oilbdsvbw27jhil3pcywrjuwiv5uzagq6i\",\"f1cadxk4yywa7hfaiz3rs23t3wmyn7cjcdy5rtm4q\",\"f3udf6vhs3xj7broosspzwjpbldee77qnrtzytpqrz2h6lfnx7sp3xwe3nn6lpg5eylpp3f7nmrqclt4zmd42a\",\"f3thj7rtskyyvqw2i4v6xg6x32rgaf5pqpkgzcdreuapfl4revnez62geu4ens2aarapuppsmok5af3rzmtgua\",\"f1t3atfumgpjhismj7pp3x63gpevxrsz4y2hgc4ci\"],\"StartEpoch\":0,\"UnlockDuration\":6307200}",
    "signer": "f0118"
  },
  {
    "id": "",
    "multisig_address": "f0120",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":3,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\",\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\",\"f1ovvm6oilbdsvbw27jhil3pcywrjuwiv5uzagq6i\",\"f1cadxk4yywa7hfaiz3rs23t3wmyn7cjcdy5rtm4q\",\"f3udf6vhs3xj7broosspzwjpbldee77qnrtzytpqrz2h6lfnx7sp3xwe3nn6lpg5eylpp3f7nmrqclt4zmd42a\",\"f3thj7rtskyyvqw2i4v6xg6x32rgaf5pqpkgzcdreuapfl4revnez62geu4ens2aarapuppsmok5af3rzmtgua\",\"f1t3atfumgpjhismj7pp3x63gpevxrsz4y2hgc4ci\"],\"StartEpoch\":0,\"UnlockDuration\":6307200}",
    "signer": "f0120"
  },
  {
    "id": "",
    "multisig_address": "f0122",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":3,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\",\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\",\"f1ovvm6oilbdsvbw27jhil3pcywrjuwiv5uzagq6i\",\"f1cadxk4yywa7hfaiz3rs23t3wmyn7cjcdy5rtm4q\",\"f3udf6vhs3xj7broosspzwjpbldee77qnrtzytpqrz2h6lfnx7sp3xwe3nn6lpg5eylpp3f7nmrqclt4zmd42a\",\"f3thj7rtskyyvqw2i4v6xg6x32rgaf5pqpkgzcdreuapfl4revnez62geu4ens2aarapuppsmok5af3rzmtgua\",\"f1t3atfumgpjhismj7pp3x63gpevxrsz4y2hgc4ci\"],\"StartEpoch\":0,\"UnlockDuration\":0}",
    "signer": "f0122"
  },
  {
    "id": "",
    "multisig_address": "f0116",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":3,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\",\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\",\"f1ovvm6oilbdsvbw27jhil3pcywrjuwiv5uzagq6i\",\"f1cadxk4yywa7hfaiz3rs23t3wmyn7cjcdy5rtm4q\",\"f3udf6vhs3xj7broosspzwjpbldee77qnrtzytpqrz2h6lfnx7sp3xwe3nn6lpg5eylpp3f7nmrqclt4zmd42a\",\"f3thj7rtskyyvqw2i4v6xg6x32rgaf5pqpkgzcdreuapfl4revnez62geu4ens2aarapuppsmok5af3rzmtgua\",\"f1t3atfumgpjhismj7pp3x63gpevxrsz4y2hgc4ci\"],\"StartEpoch\":0,\"UnlockDuration\":6307200}",
    "signer": "f0116"
  },
  {
    "id": "",
    "multisig_address": "f080",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":1,\"Signers\":[\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\"],\"StartEpoch\":0,\"UnlockDuration\":0}",
    "signer": "f080"
  },
  {
    "id": "",
    "multisig_address": "f0115",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":3,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\",\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\",\"f1ovvm6oilbdsvbw27jhil3pcywrjuwiv5uzagq6i\",\"f1cadxk4yywa7hfaiz3rs23t3wmyn7cjcdy5rtm4q\",\"f3udf6vhs3xj7broosspzwjpbldee77qnrtzytpqrz2h6lfnx7sp3xwe3nn6lpg5eylpp3f7nmrqclt4zmd42a\",\"f3thj7rtskyyvqw2i4v6xg6x32rgaf5pqpkgzcdreuapfl4revnez62geu4ens2aarapuppsmok5af3rzmtgua\",\"f1t3atfumgpjhismj7pp3x63gpevxrsz4y2hgc4ci\"],\"StartEpoch\":0,\"UnlockDuration\":6307200}",
    "signer": "f0115"
  },
  {
    "id": "",
    "multisig_address": "f0119",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":3,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\",\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\",\"f1ovvm6oilbdsvbw27jhil3pcywrjuwiv5uzagq6i\",\"f1cadxk4yywa7hfaiz3rs23t3wmyn7cjcdy5rtm4q\",\"f3udf6vhs3xj7broosspzwjpbldee77qnrtzytpqrz2h6lfnx7sp3xwe3nn6lpg5eylpp3f7nmrqclt4zmd42a\",\"f3thj7rtskyyvqw2i4v6xg6x32rgaf5pqpkgzcdreuapfl4revnez62geu4ens2aarapuppsmok5af3rzmtgua\",\"f1t3atfumgpjhismj7pp3x63gpevxrsz4y2hgc4ci\"],\"StartEpoch\":0,\"UnlockDuration\":6307200}",
    "signer": "f0119"
  }
]

🔗 zboto Link

lucaslopezf · 2024-07-17T09:22:25Z

https://app.clickup.com/t/2469579/8694vhmqk

This is the current output ( in JSON ) of the generated multisig data for the addresses in the genesis_balances.

Reference: lotus msig inspect f0121 implemented in https://github.com/filecoin-project/lotus/blob/2714a84248095f877f52ce20e737d9c8843a352a/cli/multisig.go#L188

TODO:

How to generate the ID without the TxCID ?
Should we leave the MultiSigInfo.TxCID empty ?
What should be the default MultiSigInfo.Signer when there are multiple signers ?

[
  {
    "id": "",
    "multisig_address": "f090",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":1,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\"],\"StartEpoch\":0,\"UnlockDuration\":0}",
    "signer": "f090"
  },
  {
    "id": "",
    "multisig_address": "f0117",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":3,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\",\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\",\"f1ovvm6oilbdsvbw27jhil3pcywrjuwiv5uzagq6i\",\"f1cadxk4yywa7hfaiz3rs23t3wmyn7cjcdy5rtm4q\",\"f3udf6vhs3xj7broosspzwjpbldee77qnrtzytpqrz2h6lfnx7sp3xwe3nn6lpg5eylpp3f7nmrqclt4zmd42a\",\"f3thj7rtskyyvqw2i4v6xg6x32rgaf5pqpkgzcdreuapfl4revnez62geu4ens2aarapuppsmok5af3rzmtgua\",\"f1t3atfumgpjhismj7pp3x63gpevxrsz4y2hgc4ci\"],\"StartEpoch\":0,\"UnlockDuration\":6307200}",
    "signer": "f0117"
  },
  {
    "id": "",
    "multisig_address": "f0121",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":3,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\",\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\",\"f1ovvm6oilbdsvbw27jhil3pcywrjuwiv5uzagq6i\",\"f1cadxk4yywa7hfaiz3rs23t3wmyn7cjcdy5rtm4q\",\"f3udf6vhs3xj7broosspzwjpbldee77qnrtzytpqrz2h6lfnx7sp3xwe3nn6lpg5eylpp3f7nmrqclt4zmd42a\",\"f3thj7rtskyyvqw2i4v6xg6x32rgaf5pqpkgzcdreuapfl4revnez62geu4ens2aarapuppsmok5af3rzmtgua\",\"f1t3atfumgpjhismj7pp3x63gpevxrsz4y2hgc4ci\"],\"StartEpoch\":0,\"UnlockDuration\":6307200}",
    "signer": "f0121"
  },
  {
    "id": "",
    "multisig_address": "f0118",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":3,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\",\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\",\"f1ovvm6oilbdsvbw27jhil3pcywrjuwiv5uzagq6i\",\"f1cadxk4yywa7hfaiz3rs23t3wmyn7cjcdy5rtm4q\",\"f3udf6vhs3xj7broosspzwjpbldee77qnrtzytpqrz2h6lfnx7sp3xwe3nn6lpg5eylpp3f7nmrqclt4zmd42a\",\"f3thj7rtskyyvqw2i4v6xg6x32rgaf5pqpkgzcdreuapfl4revnez62geu4ens2aarapuppsmok5af3rzmtgua\",\"f1t3atfumgpjhismj7pp3x63gpevxrsz4y2hgc4ci\"],\"StartEpoch\":0,\"UnlockDuration\":6307200}",
    "signer": "f0118"
  },
  {
    "id": "",
    "multisig_address": "f0120",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":3,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\",\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\",\"f1ovvm6oilbdsvbw27jhil3pcywrjuwiv5uzagq6i\",\"f1cadxk4yywa7hfaiz3rs23t3wmyn7cjcdy5rtm4q\",\"f3udf6vhs3xj7broosspzwjpbldee77qnrtzytpqrz2h6lfnx7sp3xwe3nn6lpg5eylpp3f7nmrqclt4zmd42a\",\"f3thj7rtskyyvqw2i4v6xg6x32rgaf5pqpkgzcdreuapfl4revnez62geu4ens2aarapuppsmok5af3rzmtgua\",\"f1t3atfumgpjhismj7pp3x63gpevxrsz4y2hgc4ci\"],\"StartEpoch\":0,\"UnlockDuration\":6307200}",
    "signer": "f0120"
  },
  {
    "id": "",
    "multisig_address": "f0122",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":3,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\",\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\",\"f1ovvm6oilbdsvbw27jhil3pcywrjuwiv5uzagq6i\",\"f1cadxk4yywa7hfaiz3rs23t3wmyn7cjcdy5rtm4q\",\"f3udf6vhs3xj7broosspzwjpbldee77qnrtzytpqrz2h6lfnx7sp3xwe3nn6lpg5eylpp3f7nmrqclt4zmd42a\",\"f3thj7rtskyyvqw2i4v6xg6x32rgaf5pqpkgzcdreuapfl4revnez62geu4ens2aarapuppsmok5af3rzmtgua\",\"f1t3atfumgpjhismj7pp3x63gpevxrsz4y2hgc4ci\"],\"StartEpoch\":0,\"UnlockDuration\":0}",
    "signer": "f0122"
  },
  {
    "id": "",
    "multisig_address": "f0116",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":3,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\",\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\",\"f1ovvm6oilbdsvbw27jhil3pcywrjuwiv5uzagq6i\",\"f1cadxk4yywa7hfaiz3rs23t3wmyn7cjcdy5rtm4q\",\"f3udf6vhs3xj7broosspzwjpbldee77qnrtzytpqrz2h6lfnx7sp3xwe3nn6lpg5eylpp3f7nmrqclt4zmd42a\",\"f3thj7rtskyyvqw2i4v6xg6x32rgaf5pqpkgzcdreuapfl4revnez62geu4ens2aarapuppsmok5af3rzmtgua\",\"f1t3atfumgpjhismj7pp3x63gpevxrsz4y2hgc4ci\"],\"StartEpoch\":0,\"UnlockDuration\":6307200}",
    "signer": "f0116"
  },
  {
    "id": "",
    "multisig_address": "f080",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":1,\"Signers\":[\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\"],\"StartEpoch\":0,\"UnlockDuration\":0}",
    "signer": "f080"
  },
  {
    "id": "",
    "multisig_address": "f0115",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":3,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\",\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\",\"f1ovvm6oilbdsvbw27jhil3pcywrjuwiv5uzagq6i\",\"f1cadxk4yywa7hfaiz3rs23t3wmyn7cjcdy5rtm4q\",\"f3udf6vhs3xj7broosspzwjpbldee77qnrtzytpqrz2h6lfnx7sp3xwe3nn6lpg5eylpp3f7nmrqclt4zmd42a\",\"f3thj7rtskyyvqw2i4v6xg6x32rgaf5pqpkgzcdreuapfl4revnez62geu4ens2aarapuppsmok5af3rzmtgua\",\"f1t3atfumgpjhismj7pp3x63gpevxrsz4y2hgc4ci\"],\"StartEpoch\":0,\"UnlockDuration\":6307200}",
    "signer": "f0115"
  },
  {
    "id": "",
    "multisig_address": "f0119",
    "height": 0,
    "tx_cid": "",
    "action_type": "Constructor",
    "value": "{\"NumApprovalsThreshold\":3,\"Signers\":[\"f1ceb34gnsc6qk5dt6n7xg6ycwzasjhbxm3iylkiy\",\"f1meqrx2ijvgrdquybafmlwgszpmc34b3kg3nohvy\",\"f1ovvm6oilbdsvbw27jhil3pcywrjuwiv5uzagq6i\",\"f1cadxk4yywa7hfaiz3rs23t3wmyn7cjcdy5rtm4q\",\"f3udf6vhs3xj7broosspzwjpbldee77qnrtzytpqrz2h6lfnx7sp3xwe3nn6lpg5eylpp3f7nmrqclt4zmd42a\",\"f3thj7rtskyyvqw2i4v6xg6x32rgaf5pqpkgzcdreuapfl4revnez62geu4ens2aarapuppsmok5af3rzmtgua\",\"f1t3atfumgpjhismj7pp3x63gpevxrsz4y2hgc4ci\"],\"StartEpoch\":0,\"UnlockDuration\":6307200}",
    "signer": "f0119"
  }
]

🔗 zboto Link

Great job, Eric! With that command, now we have the information for the genesis multisig.
Answering the questions, it's possible (actually normal) for a multisig to have multiple signers. The concept of multisig is precisely about that: a shared account with "many owners," where a certain number of signatures (threshold) are required to make transactions. Therefore, it's perfectly fine for it to have multiple signers.
Regarding the txCid, since it's a corner case and they come from the genesis, we might not have it (in fact, they're not in the canonical table).
And with the ID, as the fil-parser is now (check this link:

fil-parser/tools/multisig/multisig.go

Line 208 in 907015d

    
           ID:              tools.BuildId(tipsetCid, tx.TxTo, fmt.Sprint(tx.Height), tx.TxCid, tx.TxType),

), it will construct correctly, because even though the txCid doesn't exist, the combination of height + address + type doesn't exist in another transaction, so the ID should be unique.

lucaslopezf

Can we add a test? I mean, we could do a test with the json you provided in the example and see if everything works fine

factory.go

gotMultiSigInfo.json

feat: add factory method to parse multisig address in genesis

fd35507

ziscky marked this pull request as draft July 16, 2024 23:46

ziscky requested a review from emmanuelm41 July 16, 2024 23:49

feat: generate multisig data for the genesis addresses

5afdc82

ziscky requested a review from lucaslopezf July 17, 2024 09:03

chore: go mod tidy

2f068ec

ziscky marked this pull request as ready for review July 18, 2024 07:40

Merge branch 'dev' into feat/genesis-multisig

730a8ac

lucaslopezf reviewed Jul 18, 2024

View reviewed changes

factory.go Outdated Show resolved Hide resolved

ziscky requested a review from lucaslopezf July 18, 2024 15:15

ziscky added 2 commits July 18, 2024 22:03

fix: have empty signer

f26f55d

test: add tests

0110aab

emmanuelm41 reviewed Jul 19, 2024

View reviewed changes

gotMultiSigInfo.json Outdated Show resolved Hide resolved

fix: rm invalid file

bc5c99f

ziscky requested a review from emmanuelm41 July 19, 2024 12:33

emmanuelm41 approved these changes Jul 19, 2024

View reviewed changes

lucaslopezf approved these changes Jul 23, 2024

View reviewed changes

emmanuelm41 merged commit 702b220 into dev Jul 23, 2024
5 checks passed

emmanuelm41 deleted the feat/genesis-multisig branch July 23, 2024 12:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add factory method to parse multisig address in genesis #219

Add factory method to parse multisig address in genesis #219

ziscky commented Jul 16, 2024 •

edited

Loading

lucaslopezf commented Jul 17, 2024 •

edited

Loading

lucaslopezf left a comment

Add factory method to parse multisig address in genesis #219

Add factory method to parse multisig address in genesis #219

Conversation

ziscky commented Jul 16, 2024 • edited Loading

lucaslopezf commented Jul 17, 2024 • edited Loading

lucaslopezf left a comment

Choose a reason for hiding this comment

ziscky commented Jul 16, 2024 •

edited

Loading

lucaslopezf commented Jul 17, 2024 •

edited

Loading