Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Height Based Parsing 2 #283

Merged
merged 27 commits into from
Feb 6, 2025
Merged

Height Based Parsing 2 #283

merged 27 commits into from
Feb 6, 2025

Conversation

ziscky
Copy link
Contributor

@ziscky ziscky commented Feb 3, 2025 •
edited by zboto bot
Loading

  • Add actual height based parsing logic for all actors

🔗 zboto Link

emmanuelm41
emmanuelm41 approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems just great. A lot of code everywhere, but seems just amazing. I saw some cases where the parsing logic on the switch case is commented. Any reason why?

ziscky added 24 commits February 4, 2025 12:40
@ziscky
feat: add missing supported version ranges
e3bfaf0
@ziscky
fix: version helpers
24f4200
@ziscky
test: add version coverage test
9987af1
@ziscky
test: automatically check all actor methods are handled
7a21349
@ziscky
test: abstract away method discovery
a0880d1
@ziscky
test: add method coverage tests to all actors
0b2dffb
@ziscky
feat: add missing actor methods
02cacfe
@ziscky
test: update tests to show all failed cases
e38e4b0
@ziscky
fix: fix mismatch with v1
9fbac23
@ziscky
feat: add multisig implementation
90e3139
@ziscky
feat: add param to Parse method of Actor iface
44367aa
@ziscky
test: add actor coverage test
beef9a9
@ziscky
test: add test cases
a358c07
@ziscky
feat: add ethaccount actor parser
4ef371e
@ziscky
fix: fix multisig actor parser
92072d5
@ziscky
test: fetch latest actor version from github
406429d
@ziscky
test: refactor tests
9e438f7
@ziscky
docs: add readme
095600f
@ziscky
docs: add upgrade heights to readme
8d17345
@ziscky
docs: add descriptions
b39185c
@ziscky
test: unify v1 and v2 tests
d7429a8
@ziscky
feat: add parsing of missing tx_types
ac2ea78
@ziscky
fix: pass the network correctly
b8d6e1c
@ziscky
test: fix all tests
cdee3ff
@ziscky
Copy link
Contributor Author

ziscky commented Feb 6, 2025

It seems just great. A lot of code everywhere, but seems just amazing. I saw some cases where the parsing logic on the switch case is commented. Any reason why?

All are handled now

@ziscky ziscky merged commit f48aa20 into feat/height-based-parsing-1 Feb 6, 2025
@ziscky ziscky deleted the feat/height-based-parsing-2 branch February 6, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelm41 emmanuelm41 emmanuelm41 approved these changes

@lucaslopezf lucaslopezf Awaiting requested review from lucaslopezf

@sarataha sarataha Awaiting requested review from sarataha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ziscky @emmanuelm41