Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

clean library even further #290

Merged
merged 7 commits into from
Feb 22, 2023
Merged

clean library even further #290

merged 7 commits into from
Feb 22, 2023

Conversation

emmanuelm41
Copy link
Member

@emmanuelm41 emmanuelm41 commented Feb 22, 2023

closes #281
closes #272
closes #271
closes #270
closes #263
closes #273
closes #277

🔗 zboto Link

@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25433162
universal_receiver_hook 5165241

Datacap actor

Function Gas
name 6189377
symbol 5935709
total_supply 7962574
balance 7109645
allowance 8171595
transfer 17819074
transfer_from 25470043
burn 11559502
burn_from 18454291
allowance 11456206
increase_allowance 14216067
decrease_allowance 14219264
revoke_allowance 12852515

Init actor

Function Gas
exec 19957065
exec4 7128689

Market actor

Function Gas
add_balance 8148960
withdraw_balance 10971833
get_balance 12305347
get_deal_data_commitment 11444820
get_deal_client 6793888
get_deal_provider 6790392
get_deal_label 11650327
get_deal_term 7360657
get_deal_total_price 8910479
get_deal_client_collateral 8718625
get_deal_provider_collateral 8724805
get_deal_verified 6703462
get_deal_activation 7405101
publish_storage_deals 3090903

Power actor

Function Gas
miner_count 5303249
network_raw_power 5743847
miner_raw_power 7249105
miner_consensus_count 5313797

Precompiles actor

Function Gas
resolve_address 2395718
lookup_delegated_address (empty response) 2313419
lookup_delegated_address (address found) 2400423
resolve_eth_address 2519714

Send actor

Function Gas
send 3517062

Verifreg actor

Function Gas
add_verified_client 13619474
get_claims 10435931
extend_claim_term 11756879
remove_expired_allocations 13386854
remove_expired_claims 11756879

@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25465418
universal_receiver_hook 5197497

Datacap actor

Function Gas
name 6222937
symbol 5969269
total_supply 7996135
balance 7143290
allowance 8205239
transfer 17852718
transfer_from 25503687
burn 11593146
burn_from 18487935
allowance 11489850
increase_allowance 14249711
decrease_allowance 14252908
revoke_allowance 12886159

Init actor

Function Gas
exec 19990049
exec4 7161673

Market actor

Function Gas
add_balance 8148240
withdraw_balance 10996722
get_balance 12330236
get_deal_data_commitment 11470233
get_deal_client 6819301
get_deal_provider 6815805
get_deal_label 11675740
get_deal_term 7386070
get_deal_total_price 8935891
get_deal_client_collateral 8744038
get_deal_provider_collateral 8750218
get_deal_verified 6728875
get_deal_activation 7430514
publish_storage_deals 3090183

Power actor

Function Gas
miner_count 5326489
network_raw_power 5767087
miner_raw_power 7272430
miner_consensus_count 5337037

Precompiles actor

Function Gas
resolve_address 2395718
lookup_delegated_address (empty response) 2313419
lookup_delegated_address (address found) 2400423
resolve_eth_address 2519714

Send actor

Function Gas
send 3553339

Verifreg actor

Function Gas
add_verified_client 13653674
get_claims 10470131
extend_claim_term 11791079
remove_expired_allocations 13421055
remove_expired_claims 11791079

@emmanuelm41 emmanuelm41 merged commit 32e07b5 into master Feb 22, 2023
@emmanuelm41 emmanuelm41 deleted the fix/misc branch February 22, 2023 12:54
@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25466430
universal_receiver_hook 5198509

Datacap actor

Function Gas
name 5946245
symbol 5692577
total_supply 7719443
balance 6866622
allowance 7928699
transfer 17576051
transfer_from 25226995
burn 11316479
burn_from 18211396
allowance 11213183
increase_allowance 13973172
decrease_allowance 13976369
revoke_allowance 12609492

Init actor

Function Gas
exec 19747366
exec4 6911585

Market actor

Function Gas
add_balance 7866344
withdraw_balance 10715101
get_balance 12048615
get_deal_data_commitment 11188589
get_deal_client 6537681
get_deal_provider 6534185
get_deal_label 11394095
get_deal_term 7104450
get_deal_total_price 8654271
get_deal_client_collateral 8462418
get_deal_provider_collateral 8468598
get_deal_verified 6447255
get_deal_activation 7148894
publish_storage_deals 3017688

Power actor

Function Gas
miner_count 5067159
network_raw_power 5507757
miner_raw_power 7013123
miner_consensus_count 5077707

Precompiles actor

Function Gas
resolve_address 2395718
lookup_delegated_address (empty response) 2313419
lookup_delegated_address (address found) 2400423
resolve_eth_address 2519714

Send actor

Function Gas
send 3553339

Verifreg actor

Function Gas
add_verified_client 13653994
get_claims 10470451
extend_claim_term 11791399
remove_expired_allocations 13421375
remove_expired_claims 11791399

longfeiWan9 pushed a commit to longfeiWan9/filecoin-solidity that referenced this pull request Mar 7, 2023
* fix: remove unused vars

* feat: add inline comments for handleFilecoinMethod function

* chore: change param name and add inline comments

* chore: move balance check to inner functions

* chore: use actor id instead of address for singleton actors

* chore: change var name

* feat: add inline docs for market and miner
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant