Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sign data cap #180

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Remove sign data cap #180

merged 4 commits into from
Jan 10, 2025

Conversation

chcmedeiros
Copy link
Contributor

@chcmedeiros chcmedeiros commented Jan 7, 2025 •
edited by zboto bot
Loading

🔗 zboto Link

emmanuelm41
emmanuelm41 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know nobody is using it, but we are changing the way the app works so far. I would bump the major here. Whenever we adjust the eip191 feature, it will imply the same

@chcmedeiros
Copy link
Contributor Author

I know nobody is using it, but we are changing the way the app works so far. I would bump the major here. Whenever we adjust the eip191 feature, it will imply the same

Completely agree! I will update the version

@chcmedeiros chcmedeiros force-pushed the remove-sign-data-cap branch from 3757c3b to dedb628 Compare January 8, 2025 09:29
@chcmedeiros chcmedeiros merged commit 1dc673d into dev Jan 10, 2025
66 checks passed
@chcmedeiros chcmedeiros deleted the remove-sign-data-cap branch January 10, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelm41 emmanuelm41 emmanuelm41 approved these changes

@0xPxt 0xPxt 0xPxt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chcmedeiros @emmanuelm41 @0xPxt