-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zemu tests + pubkey caching #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aleix, a few thoughts, even for future PRs. It would be great if we use dev branch as an intermediary branch to squash smaller changes, and merge from there to master. I imagine this something like:
- changes on CI
- running zemu tests
- changes on cache
- changes on the interface (like menu, etc)
I think CI is not running because of some config on the pull_requests event filtering. I think it will work now with your changes. But they need to be on master first in order for future PRs to be executed.
Besides that, I would ask first if we can change the "developer" section on the menu, as we are maintaining it now, but we are not the ones who build it. I would ask Juan or Ainhoa. Same for license. Maybe we can change it to Apache-2.0, but not so sure. |
If we can do so, I would even change the layout to the zondax standard, like version, developed by, website, license. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment
* Implement Zemu Tests * Cache Public Key Generation * Update Menu information * Changes in CI to include Zemu Tests * Add License * Main Menu Info for all devices
* Zemu tests + pubkey caching (#2) * Implement Zemu Tests * Cache Public Key Generation * Update Menu information * Changes in CI to include Zemu Tests * Add License * Main Menu Info for all devices * Sync dev and main (#6) * Sync dev and main * Drop use of deprecated SDK function * Remove ragger tests (#8) * App ci (#9) * Trigger CI and add zemu_tests * Fix CI to run zemu_tests * bump version (#10)
No description provided.