Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zemu tests + pubkey caching #2

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Zemu tests + pubkey caching #2

merged 6 commits into from
Nov 20, 2024

Conversation

0xPxt
Copy link
Collaborator

@0xPxt 0xPxt commented Nov 14, 2024

No description provided.

Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aleix, a few thoughts, even for future PRs. It would be great if we use dev branch as an intermediary branch to squash smaller changes, and merge from there to master. I imagine this something like:

  • changes on CI
  • running zemu tests
  • changes on cache
  • changes on the interface (like menu, etc)

I think CI is not running because of some config on the pull_requests event filtering. I think it will work now with your changes. But they need to be on master first in order for future PRs to be executed.

@emmanuelm41
Copy link
Member

Besides that, I would ask first if we can change the "developer" section on the menu, as we are maintaining it now, but we are not the ones who build it. I would ask Juan or Ainhoa. Same for license. Maybe we can change it to Apache-2.0, but not so sure.

@emmanuelm41
Copy link
Member

If we can do so, I would even change the layout to the zondax standard, like version, developed by, website, license.

@0xPxt 0xPxt changed the base branch from master to dev November 18, 2024 09:07
src/menu_nbgl.c Outdated Show resolved Hide resolved
Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment

@0xPxt 0xPxt merged commit 7ea18c5 into dev Nov 20, 2024
emmanuelm41 pushed a commit that referenced this pull request Nov 21, 2024
* Implement Zemu Tests

* Cache Public Key Generation

* Update Menu information

* Changes in CI to include Zemu Tests

* Add License

* Main Menu Info for all devices
0xPxt added a commit that referenced this pull request Nov 25, 2024
* Zemu tests + pubkey caching (#2)

* Implement Zemu Tests

* Cache Public Key Generation

* Update Menu information

* Changes in CI to include Zemu Tests

* Add License

* Main Menu Info for all devices

* Sync dev and main (#6)

* Sync dev and main

* Drop use of deprecated SDK function

* Remove ragger tests (#8)

* App ci (#9)

* Trigger CI and add zemu_tests

* Fix CI to run zemu_tests

* bump version (#10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants