fix hash corruption in initFCMTokens() #425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
initFCMTokens
the call togettimeofday()
returns a two element array in this context, which then corrupts theactive_connections
element.This in turn causes an invalid entry to be written to tokens.txt with an empty token value
e.g.
FCM token entry in
@active_connections
:tokens.txt:
Calling
gettimeofday()
in a scalar context produces a much happier looking hash: