Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZM Event web paging issue #3510

Closed
basildane opened this issue Jun 22, 2022 · 5 comments
Closed

ZM Event web paging issue #3510

basildane opened this issue Jun 22, 2022 · 5 comments
Milestone

Comments

@basildane
Copy link

Describe Your Environment

  • Version of ZoneMinder [1.36.19]
  • How you installed ZoneMinder [PPA]
  • Full name and version of OS [Ubuntu 20.04]
  • Browser name and version [Brave 1.40.105]

If the issue concerns a camera

Describe the bug
When "paging", using the page controls at the bottom of the events page, the current page is remembered between sessions and events. For example, you open a camera and browse to page 5. Open another camera, the NEW camera you just opened is displaying page 5. It should default to page 1. Even worse, when visiting the page even days later, it remembers what page you were on in the last session and puts you into that page by default. So you end up looking at events that are days old wondering why, then you have to go to the bottom and click "1" - every single time.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Console
  2. Click on any channel
  3. Click on a page (ie 5)
  4. Go to another channel
  5. You are on page 5 on the Other channel

Expected behavior
When opening the application fresh, or when changing to a new channel, you should start at page 1.

Debug Logs

@welcome
Copy link

welcome bot commented Jun 22, 2022

Thanks for opening your first issue here! Just a reminder, this forum is for Bug Reports only. Be sure to follow the issue template!

@basildane
Copy link
Author

The problem is that the ZoneMinder web page sets a cookie: zmEventsTable.bs.table.pageNumber
This page number is remembered and puts you on an unexpected page every time you open the application.

@connortechnology
Copy link
Member

The issue is that we use this cookie feature to remember the visible columns, etc as well. It would be best to not use it for paging I think.

@connortechnology
Copy link
Member

SO I looked into it. We can turn off the cookie for the pagenumber no problem. However then if we do a page reload, it puts us back on page 1.

I kinda think that is preferable to the current behaviour. @knight-of-ni do you have any thoughts on the matter?

@connortechnology connortechnology added this to the 1.36.33 milestone Jan 3, 2023
@basildane
Copy link
Author

Another option would be to include the channel number in the cookie, so the cookie would intelligently follow the page for the correct channel. But, this sounds good too.

connortechnology pushed a commit that referenced this issue Feb 16, 2023
… so that each and every filter gets it;s own pagination saved. Fixes #3510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants