Bootstrap skin #546
Closed
Bootstrap skin #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
commit 1a83b30
|
This was referenced Nov 1, 2014
Closed
This reverts commit 4b6cf9c.
You should now be able to see a monitor's zones by clicking on the respective 'Edit' link. From there, you'll see a list view of that monitor's Zones. From there, you can click on the Zone name, which will bring up the details for that zone. You can not yet save zones, and not all of the values for that zone are displayed.
I wish I knew about this plugin months ago. By default PDO and CakePHP cast int as string. This prevents me from using `<input type="number">`, as the modle that the input is bound to is actually a string, not an int. Crud by default casts int back to int via ApiTransformationListener It also has a bunch of other features which makes the life of a REST / CRUD developer easier.
* Add routes for each individual options tab * Add options files for each category * Use ui-router with ui-view for tab functionality Previously the options tabs were dynamically generated from the API, and returned as HTML-formed json. These were then dynamically inserted into the page. From there, tab functionality was added with bootstrap + jquery. ui-router broke that tab functionality.
This commits adds some styling for the stacked tabs in the Options and Monitors views.
This commit will pass in a $scope.configData array to the 'options' state before the page loads. This ensures that the config data is in scope before the page loads.
We're now grabbing only the json from the api, passing it through the Crud plugin so that ints stay as ints, and then assigning the json to the scope via app.js resolve. * Saving Config is not tested here. * This commit may deprecate the ConfigParserComponent * Options must be saved before changing the tab, lest they are lost. * That'll be fixed in another commit.
|
I'm going to close this PR, and create a second one which targets a branch off of master, instead of master itself. That way I can get this into the hands of more people earlier, without having to worry about screwing things up in master. |
|
This code is now tracked in the angular-ui branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to fix bugs in the flat skin and decided to start over... ish.
Reusing most of the existing ZM framework - just changing client side to look better and be easier to maintain. That means using bootstrap for css.
This PR is not ready to merge, but I would like feedback as I go through and make my changes. This PR should however work fine if it were merged - it just isn't complete.