Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On windows, a preview doesn't close when you quit. #575

Closed
mgrazebrook opened this issue May 31, 2017 · 3 comments
Closed

On windows, a preview doesn't close when you quit. #575

mgrazebrook opened this issue May 31, 2017 · 3 comments
Labels
bug Issues that report (apparent) bugs. lib-Pygame Issues pertaining to dependency Pygame.

Comments

@mgrazebrook
Copy link

I'm using windows, Python 3.6 and moviepy 0.2.3.2, run through jupyter notebook.

clip.ipython_display() runs but doesn't produce any visible result.

clip.preview() pops up a PyGame window. The command ends on ESC. But the window doesn't pop down. I can close it by importing pygame and calling pygame.quit()
mgaitan pushed a commit to mgaitan/moviepy that referenced this issue Apr 16, 2018
add a decorator to quit pygame
d394f84 
This fix Zulko#575
mgaitan pushed a commit to mgaitan/moviepy that referenced this issue Apr 16, 2018
add a decorator to quit pygame
f6c8722 
This fix Zulko#575
@mgaitan mgaitan mentioned this issue Apr 16, 2018
Closed
@keikoro keikoro added the lib-Pygame Issues pertaining to dependency Pygame. label Oct 5, 2020
@keikoro keikoro mentioned this issue Oct 6, 2020
Closed
@keikoro keikoro added the bug Issues that report (apparent) bugs. label Oct 6, 2020
jacobwhiteman17 added a commit to jlindo33/moviepy that referenced this issue Apr 8, 2021
@jacobwhiteman17
Update preview.py, fix issue Zulko#575
938eb37 
Fixed issue Zulko#575. Added two pg.quit statements at lines 146 and 162. For line 146, this statement adds quit functionality for " event.type == pg.KEYDOWN and event.key == pg.K_ESCAPE". This allows the window to close whenever the event triggers. For line 162, once the for loop ends (the video ends), the window closes instead of crashing.
@Victrollia Victrollia mentioned this issue Apr 9, 2021
Merged
4 tasks
@mondeja
Copy link
Collaborator

mondeja commented Apr 15, 2021 •
edited
Loading

The clip.preview() problem has been successfully fixed in #1537.

mondeja pushed a commit that referenced this issue Apr 15, 2021
@Victrollia @jacobwhiteman17
Fixed 'clip.preview()' crashing at exit when running inside Jupyter N…
2f7e434 
…otebook in Windows (#1537)

* Update preview.py, fix issue #575

Fixed issue #575. Added two pg.quit statements at lines 146 and 162. For line 146, this statement adds quit functionality for " event.type == pg.KEYDOWN and event.key == pg.K_ESCAPE". This allows the window to close whenever the event triggers. For line 162, once the for loop ends (the video ends), the window closes instead of crashing.

Co-authored-by: jacobwhiteman17 <54951159+jacobwhiteman17@users.noreply.github.com>
@mondeja
Copy link
Collaborator

mondeja commented Apr 15, 2021

clip.ipython_display() runs but doesn't produce any visible result.

I can't reproduce this problem with moviepy master and latest Jupyter Notebook version (notebook==6.3.0). Given the age of the report, it is likely that it has been fixed or is no longer a problem with current dependencies. I'm closing this, if someones can reproduce it, please report it here and we'll investigate again.

@mondeja mondeja closed this as completed Apr 15, 2021
@mgrazebrook
Copy link
Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues that report (apparent) bugs. lib-Pygame Issues pertaining to dependency Pygame.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add a decorator to quit pygame mgaitan/moviepy
3 participants
@keikoro @mgrazebrook @mondeja