-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AudioClip I/O #1108
Fix AudioClip I/O #1108
Conversation
All checks have passed! What's the next step to have this merged? (It's my first time to make a pull request, so forgive me if I'm asking anything stupid) |
Hey @MaigoAkisame thanks so much for making this PR! You've done everything you need to for now, it is just waiting for a maintainer to check that we're happy with it and then we can merge it into the master branch. |
Thank you! |
Co-Authored-By: Martín Gaitán <gaitan@gmail.com>
There has been no activity for almost 2 weeks. Is someone gonna merge this? |
Closes #1174. Thanks |
Sorry, my mistake. Please merge the changes back in at MaigoAkisame#1. |
Is that something I need to do? What do I need to do exactly? |
Please just merge MaigoAkisame#1, and I think that I can sort the rest out after that. This is totally my fault, but I can't work out how to fix it without you doing that. |
Fix PR - sorry!
Sure! I just did it. |
Great, I'll merge when the tests finish. You'll be happy to know that this PR fixed #1174 perfectly. |
The existing code does not read and write audio signals without changing them.
I've fixed some of the related code, and added a
test_audioclip_io
test to ensure the audio does not change during I/O.tests/