Fix `AttributeError: 'NoneType' object has no attribute 'stdout'` for all versions of Python #1185

tburrows13 · 2020-05-07T16:00:34Z

This supersedes #1059, and includes the test from it, but solves the problem in a slightly different way, as suggested in #938. However, without the self.proc.wait() line, the change made it incompatible with Python <3.7 on Windows, which is why the fix has taken so long. With this PR, the dealings with subprocess.Popen should be consistent between VideoFileClips and AudioFileClips.

I could see an argument for implementing #1059 for both Video and Audio, but because this fix is intended for the v1.0 branch, I didn't want to change the recommended way of closing/deleting clips.

I intend to release this very soon as a v1.0.3, and then merge it into the v2 branch.

coveralls · 2020-05-07T16:05:51Z

Coverage increased (+0.3%) to 65.16% when pulling 72e9c69 on tburrows13:fix-v1.0-4 into d54c195 on Zulko:v1.0.x.

… all versions of Python (#1185) Release v1.0.3

tburrows13 · 2020-06-10T12:31:10Z

Hello @SimoneMender. I'm sorry to hear that you are still experiencing problems. Would you be able to post the complete error callback, a small complete piece of code that demonstrates the error, and (if possible) a mp4 file that fails when used as input?

These 3 things should make it very easy for someone to find out where the error is and fix it.

tburrows13 · 2020-06-10T12:35:03Z

@SimoneMender sorry, your comment appear twice on my screen, so I deleted the second one. Now the first one has disappeared as well, so that might have been my fault.

Here's your original message:

Hi all,

I still get the error message:
s = self.proc.stdout.read(self.nchannels*chunksize*self.nbytes)
AttributeError: 'NoneType' object has no attribute 'stdout'"
It is very strange that this is dependent on the video file. I leave the code exactly the same, but if I use a different mp4 file as input, an mp4 output is created without any problems. I would be happy if someone has another idea where the mistake could come from. Thanks!

Ubuntu 16.04.6
Python 3.7.7

Problem occurs with:

moviepy 2.0.0.dev1
moviepy-1.0.3
moviepy-1.0.2
moviepy-1.0.1
moviepy-1.0.0

SimoneMender · 2020-06-10T13:18:43Z

@tburrows13 Thanks for your quick answer!

Here is the complete error message:

Moviepy - Building video test.mp4.
MoviePy - Writing audio in testTEMP_MPY_wvf_snd.mp3
chunk:   0%|                                                                                        | 0/67 [00:00<?, ?it/s, now=None]Traceback (most recent call last):
  File "make_movie_issue.py", line 64, in <module>
    stop = 23 # and change this to 4, there will be no problems
  File "make_movie_issue.py", line 56, in main
    final_clip.write_videofile('test.mp4', 20)
  File "<decorator-gen-55>", line 2, in write_videofile
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/decorators.py", line 54, in requires_duration
    return f(clip, *a, **k)
  File "<decorator-gen-54>", line 2, in write_videofile
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/decorators.py", line 135, in use_clip_fps_by_default
    return f(clip, *new_a, **new_kw)
  File "<decorator-gen-53>", line 2, in write_videofile
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/decorators.py", line 22, in convert_masks_to_RGB
    return f(clip, *a, **k)
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/video/VideoClip.py", line 298, in write_videofile
    logger=logger)
  File "<decorator-gen-45>", line 2, in write_audiofile
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/decorators.py", line 54, in requires_duration
    return f(clip, *a, **k)
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/audio/AudioClip.py", line 210, in write_audiofile
    logger=logger)
  File "<decorator-gen-9>", line 2, in ffmpeg_audiowrite
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/decorators.py", line 54, in requires_duration
    return f(clip, *a, **k)
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/audio/io/ffmpeg_audiowriter.py", line 169, in ffmpeg_audiowrite
    logger=logger):
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/audio/AudioClip.py", line 86, in iter_chunks
    fps=fps, buffersize=chunksize)
  File "<decorator-gen-44>", line 2, in to_soundarray
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/decorators.py", line 54, in requires_duration
    return f(clip, *a, **k)
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/audio/AudioClip.py", line 127, in to_soundarray
    snd_array = self.get_frame(tt)
  File "<decorator-gen-11>", line 2, in get_frame
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/decorators.py", line 89, in wrapper
    return f(*new_a, **new_kw)
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/Clip.py", line 93, in get_frame
    return self.make_frame(t)
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/audio/AudioClip.py", line 297, in make_frame
    for c, part in zip(self.clips, played_parts)
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/audio/AudioClip.py", line 298, in <listcomp>
    if (part is not False)]
  File "<decorator-gen-11>", line 2, in get_frame
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/decorators.py", line 89, in wrapper
    return f(*new_a, **new_kw)
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/Clip.py", line 93, in get_frame
    return self.make_frame(t)
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/Clip.py", line 136, in <lambda>
    newclip = self.set_make_frame(lambda t: fun(self.get_frame, t))
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/Clip.py", line 187, in <lambda>
    return self.fl(lambda gf, t: gf(t_func(t)), apply_to,
  File "<decorator-gen-11>", line 2, in get_frame
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/decorators.py", line 89, in wrapper
    return f(*new_a, **new_kw)
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/Clip.py", line 93, in get_frame
    return self.make_frame(t)
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/audio/io/AudioFileClip.py", line 77, in <lambda>
    self.make_frame = lambda t: self.reader.get_frame(t)
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/audio/io/readers.py", line 182, in get_frame
    self.buffer_around(fr_min)
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/audio/io/readers.py", line 243, in buffer_around
    self.seek(new_bufferstart)
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/audio/io/readers.py", line 141, in seek
    self.skip_chunk(pos-self.pos)
  File "/home/simone/.local/SMDanaconda/envs/movie/lib/python3.7/site-packages/moviepy/audio/io/readers.py", line 103, in skip_chunk
    s = self.proc.stdout.read(self.nchannels*chunksize*self.nbytes)
AttributeError: 'NoneType' object has no attribute 'stdout'

While creating an example, I found another curiosity. When I call my function with:

if __name__ == '__main__':
    main(
        w=1280,
        h=720,
        clip="medicaltraining.mp4",
        start = 20,
        stop = 23
    )

I'll create the error above. When I change the start and stop time of my function to

if __name__ == '__main__':
    main(
        w=1280,
        h=720,
        clip="medicaltraining.mp4",
        start = 2,
        stop = 4
    )

mp4 file is produced without any problems. As the input file "medicaltraining.mp4", is longer than 23 s I can't understand this.
Find code and "medicaltraining.mp4" here: https://drive.google.com/file/d/1QH9vjrYBFvJmlnj222KCvYnSanzMu29n/view?usp=sharing

tburrows13 · 2020-06-10T14:35:47Z

Ok, I've investigated and found a fix. Your problem is that you are closing the VideoFileClip prematurely by using it with the with ... as. When that exits, it closes the clip. Once the clip is closed, you cannot then do anything with it, such as use it as a base for writing to video.

The solution is to indent the following 2 lines:

    final_clip = mp.CompositeVideoClip(
        [
            clip_margin,
            txt_signatur.set_duration(clip_margin.duration),
            txt_title.set_duration(clip_margin.duration),
        ]
    )

    final_clip.write_videofile('test.mp4', 20)

so that they are inside the with section or stop using with entirely and just assign c as a normal variable.

The reason that it works when start=2, stop=4 is that when the clip is created, it stores some data near time=0 in its buffer, which apparently includes at least 4 seconds of data, so it never actually reads from the disk after closing.

SimoneMender · 2020-06-10T14:59:36Z

That solved my problem! Thank you very much!

tburrows13 added 3 commits May 7, 2020 15:42

Only add test

6d7615b

Add self.proc.wait()

deb507d

Remove AudioFileClip.__del__ as well

960dbc0

Add changelog and increment version number

72e9c69

tburrows13 merged commit db19920 into Zulko:v1.0.x May 7, 2020

tburrows13 mentioned this pull request May 7, 2020

FIX: OSError: [WinError 6] The handle is invalid #1066

Closed

Technerder mentioned this pull request May 7, 2020

AttributeError: 'NoneType' object has no attribute 'stdout' #938

Closed

This was referenced May 7, 2020

Don't close the audio reader which might be linked from a shallow copy. #1059

Closed

I'm not able to use "CompositeVideoClip" with audio set to True #1095

Closed

AttributeError: 'NoneType' object has no attribute 'get_frame' #1025

Closed

tburrows13 deleted the fix-v1.0-4 branch May 7, 2020 20:09

tburrows13 added a commit that referenced this pull request May 7, 2020

Fix AttributeError: 'NoneType' object has no attribute 'stdout' for…

dd5aa72

… all versions of Python (#1185) Release v1.0.3

tburrows13 mentioned this pull request Jun 3, 2020

defunct ffmpeg processes removed after clip.close() #750

Closed

Repository owner deleted a comment from SimoneMender Jun 10, 2020

tburrows13 added the bug-fix For PRs and issues solving bugs. label Jun 16, 2020

tburrows13 mentioned this pull request Jun 16, 2020

defunct ffmpeg processes left even after clip.close() #745

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `AttributeError: 'NoneType' object has no attribute 'stdout'` for all versions of Python #1185

Fix `AttributeError: 'NoneType' object has no attribute 'stdout'` for all versions of Python #1185

tburrows13 commented May 7, 2020

coveralls commented May 7, 2020 •

edited

Loading

tburrows13 commented Jun 10, 2020 •

edited

Loading

tburrows13 commented Jun 10, 2020

SimoneMender commented Jun 10, 2020 •

edited

Loading

tburrows13 commented Jun 10, 2020 •

edited

Loading

SimoneMender commented Jun 10, 2020

Fix AttributeError: 'NoneType' object has no attribute 'stdout' for all versions of Python #1185

Fix AttributeError: 'NoneType' object has no attribute 'stdout' for all versions of Python #1185

Conversation

tburrows13 commented May 7, 2020

coveralls commented May 7, 2020 • edited Loading

tburrows13 commented Jun 10, 2020 • edited Loading

tburrows13 commented Jun 10, 2020

SimoneMender commented Jun 10, 2020 • edited Loading

tburrows13 commented Jun 10, 2020 • edited Loading

SimoneMender commented Jun 10, 2020

Fix `AttributeError: 'NoneType' object has no attribute 'stdout'` for all versions of Python #1185

Fix `AttributeError: 'NoneType' object has no attribute 'stdout'` for all versions of Python #1185

coveralls commented May 7, 2020 •

edited

Loading

tburrows13 commented Jun 10, 2020 •

edited

Loading

SimoneMender commented Jun 10, 2020 •

edited

Loading

tburrows13 commented Jun 10, 2020 •

edited

Loading