-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrections to video duration detection #1222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2020
4 tasks
Most of the original comment is outdated. I've reverted the decoding behaviour back to how it was before with an option to fully decode the file if the user needs it. I've also changed the default fps source to 'fps' rather than 'tbr' as 'tbr' was causing quite a few issues. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #1063. This PR essentially does what #1063 was supposed to do.
The linked StackOverflow post that inspired #1063 was correct, but it was only addressing audio files. In order for this to apply to audio and video, I've removed the
-acodec
(audio codec) argument and replaced it with the-codec
argument which applies to all streams (audio and video). Without this change, FFmpeg decodes every video frame which takes a long time.Secondly, here is the output from FFmpeg with the 2 different commands:
But looking at the code that extracts the duration from this output, without this PR, it still reads the
Duration:
data, not thetime=
data from the end.I've also simplified the code by removing the special case for GIFs, as they have always been using the better way of doing it.