Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change file extension for audio file and resizing parameters during… #1241

Merged

Conversation

jay3ss
Copy link
Contributor

@jay3ss jay3ss commented Jun 20, 2020

…crop of clip

The current version of youtube-dl appends webm to the frontier.mp4 file so that it's now frontier.mp4.webm, so I've updated the code in the example to reflect that (I couldn't find the parameters in youtube-dl's documentation to force the frontier.mp4 file name). Also, I changed the resizing parameters in the cropping of the video to match (as best as I could) the example posted to YouTube.

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it
  • I have formatted my code using black -t py36

@coveralls
Copy link

coveralls commented Jun 20, 2020

Coverage Status

Coverage remained the same at 67.597% when pulling f299440 on jay3ss:fix-dancing-knights-example-resizing-video into c4396fb on Zulko:master.

@tburrows13 tburrows13 added the examples Related to the code examples included in the documentation (examples dir). label Jun 21, 2020
@tburrows13
Copy link
Collaborator

Hello, thanks for making this change. I've made a slight adjustment that I think will reduce confusion.

@jay3ss
Copy link
Contributor Author

jay3ss commented Jun 21, 2020

Thanks for the update, that's much clearer.

@tburrows13 tburrows13 merged commit b47c29e into Zulko:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Related to the code examples included in the documentation (examples dir).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants