Add change_duration flag to Clip.set_fps() #1329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull fixes #1069 by adding a new
change_duration=False
flag toClip.set_fps
. When False, original behaviour is conserved, When true, the speed and duration of the video are both changed when the fps is changed (so that all frames are preserved 1:1).I have yet to write tests but on some test videos the behaviour is as expected.
tests/
black -t py36