Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for loop using BitmapClip #1368 #1370

Merged
merged 4 commits into from
Nov 3, 2020
Merged

Conversation

somstrom
Copy link
Contributor

@somstrom somstrom commented Nov 2, 2020

I added some tests for loops using BitmapClip and they passed.

  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have formatted my code using black -t py36

@coveralls
Copy link

coveralls commented Nov 2, 2020

Coverage Status

Coverage increased (+0.07%) to 67.525% when pulling 6e1e09c on somstrom:loop-tests into 344aa04 on Zulko:master.

@tburrows13
Copy link
Collaborator

These tests are great. However, I'd like to ask that you keep the original 3 tests as well (you can comment out the failing ones). The reason that the they fail is because they include audio and mask clips, which are not replicated in the BitmapClip tests (I suppose that they could be, but I've never done that, so I wouldn't have expected you to!).

@somstrom
Copy link
Contributor Author

somstrom commented Nov 2, 2020

I added test for infinite loop and tests for fadein using BitmapClip

@somstrom
Copy link
Contributor Author

somstrom commented Nov 2, 2020

I would like to fix loop issue, so I got one question.

Loop function is called 2 times so previous_duration is rewritten. But i can't figure out why it is called 2 times. So my question is why is loop function called 2 times.

I have replaced previous_duration with numeric value of clip duration and it works.

@tburrows13
Copy link
Collaborator

Check the Gitter for discussion - someone else is also working on it :)

@somstrom somstrom changed the title Tests for loop using BitmapClip #1368 Formated code #1368 Nov 3, 2020
@somstrom somstrom changed the title Formated code #1368 Tests for loop using BitmapClip #1368 Nov 3, 2020
@ParikhNand ParikhNand mentioned this pull request Nov 3, 2020
2 tasks
@tburrows13
Copy link
Collaborator

Good job, I'm happy to merge.

@tburrows13 tburrows13 merged commit 4185e51 into Zulko:master Nov 3, 2020
@mondeja mondeja mentioned this pull request Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants