-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for loop using BitmapClip #1368 #1370
Conversation
These tests are great. However, I'd like to ask that you keep the original 3 tests as well (you can comment out the failing ones). The reason that the they fail is because they include audio and mask clips, which are not replicated in the BitmapClip tests (I suppose that they could be, but I've never done that, so I wouldn't have expected you to!). |
I added test for infinite loop and tests for fadein using BitmapClip |
I would like to fix loop issue, so I got one question. Loop function is called 2 times so previous_duration is rewritten. But i can't figure out why it is called 2 times. So my question is why is loop function called 2 times. I have replaced |
Check the Gitter for discussion - someone else is also working on it :) |
Good job, I'm happy to merge. |
I added some tests for loops using BitmapClip and they passed.
tests/
black -t py36