Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MacOSX tests with temporal workaround for python.app issue #1412

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Fix MacOSX tests with temporal workaround for python.app issue #1412

merged 1 commit into from
Jan 11, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 11, 2021

The error is documented here, and the solution clearly explained here. This patch should be updated when the issue with python.app installation would be fixed.

Closes #1409

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it
  • I have formatted my code using black -t py36

@mondeja mondeja marked this pull request as draft January 11, 2021 16:17
@mondeja mondeja changed the title Fix MacOSX tests with python.app issue temporal workaround Fix MacOSX tests with temporal workaround for python.app issue Jan 11, 2021
@mondeja mondeja marked this pull request as ready for review January 11, 2021 16:20
@tburrows13 tburrows13 mentioned this pull request Jan 11, 2021
Closed
2 tasks
@tburrows13 tburrows13 added the tests Related to individual tests in the test suite or running the test suite. label Jan 11, 2021
@tburrows13 tburrows13 merged commit 9343f6c into Zulko:master Jan 11, 2021
@mondeja mondeja deleted the fix-osx-tests branch January 11, 2021 16:32
@tburrows13 tburrows13 added tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo. and removed tests Related to individual tests in the test suite or running the test suite. labels Jan 11, 2021
@mondeja mondeja mentioned this pull request Jan 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI is failing
2 participants
@mondeja @tburrows13