Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test properly 'blackwhite' FX using 'BitmapClip' #1430

Merged
merged 2 commits into from
Jan 15, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 12, 2021

blackwhite FX properly tested using BitmapClip class. Contributes to #1355.

  • Added class property DEFAULT_COLOR_DICT to BitmapClip class to avoid the repeat of default colors definition. Let me know if this is not wanted.
  • Tested all posible argument combinations.
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly explained unusual or unexpected code in the comments around it
  • I have formatted my code using black -t py36

@mondeja mondeja changed the title Test 'blackwhite' FX using 'BitmapClip' Test properly 'blackwhite' FX using 'BitmapClip' Jan 12, 2021
@mondeja mondeja force-pushed the tests/bw-fx-bitmapclip branch from 0bc5a2d to 876dd8f Compare January 12, 2021 23:14
@tburrows13 tburrows13 added the tests Related to individual tests in the test suite or running the test suite. label Jan 13, 2021
@mondeja mondeja added the fx Related to advanced effects applied via clip.fx(), or effects in general. label Jan 15, 2021
moviepy/video/VideoClip.py Show resolved Hide resolved
@mondeja mondeja merged commit 727276f into Zulko:master Jan 15, 2021
tburrows13 pushed a commit to tburrows13/moviepy that referenced this pull request Jan 19, 2021
* Test 'blackwhite' FX using 'BitmapClip'

* Improved 'test_blackwhite' comments and refactorized a bit
@tburrows13 tburrows13 mentioned this pull request Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fx Related to advanced effects applied via clip.fx(), or effects in general. tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants