Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'rewrite_audio' argument from 'VideoClip.write_videofile' #1440

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 14, 2021

This argument does nothing so should be removed. Related to #1339.

@mondeja mondeja added the refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. label Jan 14, 2021
@mondeja mondeja closed this Jan 14, 2021
@mondeja mondeja deleted the remove-rewrite_audio branch January 14, 2021 18:21
@mondeja mondeja restored the remove-rewrite_audio branch January 14, 2021 18:21
@mondeja mondeja reopened this Jan 14, 2021
@mondeja mondeja merged commit 08e0148 into Zulko:master Jan 14, 2021
tburrows13 pushed a commit to tburrows13/moviepy that referenced this pull request Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants