Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve 'resizer' function discovering in 'moviepy.video.fx.resize' #1444

Merged
merged 3 commits into from
Jan 18, 2021
Merged

Improve 'resizer' function discovering in 'moviepy.video.fx.resize' #1444

merged 3 commits into from
Jan 18, 2021
+98 −33

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 14, 2021 •
edited by tburrows13
Loading

  • Improve resizer function autodiscovering in video.fx.resize. If any resizer can't be found, shows why and how to solve the problem, like (example without install PIL nor OpenCV, using Scipy v1.4.1):
ImportError: fx resize needs OpenCV or Scipy or PIL
- scipy.misc.imresize not found (was removed in scipy v1.3.0, you are using v1.4.1, install 'Pillow')
- PIL not found (install 'Pillow')
- OpenCV not found (install 'opencv-python')

  • Scipy v1.3.0 removed the function scipy.misc.imresize and, since moviepy supports that version, this lacking is checked and shown to the user if needed.

  • I have formatted my code using black -t py36

@mondeja mondeja added the refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. label Jan 14, 2021
@mondeja mondeja changed the title Add better 'resizer' function discovering in 'moviepy.video.fx.resize' Improve 'resizer' function discovering in 'moviepy.video.fx.resize' Jan 14, 2021
@mondeja mondeja added the fx Related to advanced effects applied via clip.fx(), or effects in general. label Jan 15, 2021
@mondeja mondeja marked this pull request as draft January 15, 2021 12:41
@mondeja mondeja marked this pull request as ready for review January 15, 2021 12:46
@mondeja mondeja added the video Related to VideoClip and related classes, or handling of video in general. label Jan 15, 2021
@mondeja mondeja marked this pull request as draft January 16, 2021 02:04
@mondeja mondeja force-pushed the better-fx-resizer-discovering branch from 76e3842 to 66941d1 Compare January 16, 2021 11:51
@mondeja mondeja marked this pull request as ready for review January 16, 2021 11:53
@coveralls
Copy link

coveralls commented Jan 16, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 65.905% when pulling 64dffb5 on mondeja:better-fx-resizer-discovering into 646674c on Zulko:master.

@mondeja mondeja requested a review from tburrows13 January 16, 2021 21:59
@mondeja mondeja merged commit 2066244 into Zulko:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tburrows13 tburrows13 Awaiting requested review from tburrows13

Assignees
No one assigned
Labels
fx Related to advanced effects applied via clip.fx(), or effects in general. refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. video Related to VideoClip and related classes, or handling of video in general.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mondeja @coveralls @tburrows13