Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move 'sintel_with_15_chapters.mp4' to 'media/' directory #1446

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Move 'sintel_with_15_chapters.mp4' to 'media/' directory #1446

merged 1 commit into from
Jan 15, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 15, 2021

Just to maintain all media files in one directory, it seems confusing that file being located at tests/resource/.

@mondeja mondeja added refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. tests Related to individual tests in the test suite or running the test suite. labels Jan 15, 2021
@mondeja mondeja merged commit 8ec8f53 into Zulko:master Jan 15, 2021
tburrows13 pushed a commit to tburrows13/moviepy that referenced this pull request Jan 19, 2021
@mondeja @tburrows13
Move 'sintel_with_15_chapters.mp4' to 'media/' directory (Zulko#1446)
b3713f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tburrows13 tburrows13 tburrows13 approved these changes

Assignees
No one assigned
Labels
refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mondeja @tburrows13