Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency version requirements #1455

Merged
merged 2 commits into from
Jan 16, 2021

Conversation

tburrows13
Copy link
Collaborator

@tburrows13 tburrows13 commented Jan 16, 2021

Some of these were very out of date, so I went through them and updated them to current versions. I removed the version restrictions on the optional requirements because they are used so little in moviepy, and only in niche corners of it that in my opinion there is no point spending a lot of time ensuring that each version is properly compatible. They are very likely to be compatible anyway because of how little each library is used.
Better to let users use whichever version of those libraries that they like.

Closes #1454.

@tburrows13 tburrows13 added the dependencies For issues and PRs concerning project dependencies. See lib- prefix for individual dependencies. label Jan 16, 2021
@coveralls
Copy link

coveralls commented Jan 16, 2021

Coverage Status

Coverage remained the same at 66.018% when pulling a699cb9 on tburrows13:update-dependencies into cc02587 on Zulko:master.

Copy link
Collaborator

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@mondeja mondeja merged commit 646674c into Zulko:master Jan 16, 2021
tburrows13 added a commit to tburrows13/moviepy that referenced this pull request Jan 19, 2021
* Update dependency version requirements

* Move pygame from doc_reqs to optional_reqs
@mondeja mondeja mentioned this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies For issues and PRs concerning project dependencies. See lib- prefix for individual dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants