Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise test suite speed #1463

Merged
merged 2 commits into from
Jan 17, 2021
Merged

Optimise test suite speed #1463

merged 2 commits into from
Jan 17, 2021

Conversation

tburrows13
Copy link
Collaborator

I noticed that some tests were taking far longer than they needed to. This was usually doing write_videofile on a long clip.

Here's the speed differences on my laptop between before and after these changes

Units are seconds
Total:
1m43s > 53.9

test_PR.py:
3.8 -> 2.9

test_Videos.py:
3.2 -> 0.3

test_examples.py:
4.6 -> 1.2

test_loop():
26.8 -> 2.5

test_resize():
2.8 -> 0.7

test_issues.py:
15.6 -> 5.1

test_subtitles():
11.2 -> 7.4

@tburrows13 tburrows13 added the tests Related to individual tests in the test suite or running the test suite. label Jan 17, 2021
@coveralls
Copy link

coveralls commented Jan 17, 2021

Coverage Status

Coverage remained the same at 66.018% when pulling 0839e70 on tburrows13:optimise-tests into 646674c on Zulko:master.

Copy link
Collaborator

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'm seeing all fine 👍

@mondeja mondeja merged commit ebd4925 into Zulko:master Jan 17, 2021
@tburrows13 tburrows13 deleted the optimise-tests branch January 17, 2021 17:09
tburrows13 added a commit to tburrows13/moviepy that referenced this pull request Jan 19, 2021
* Optimise test suite speed

* Apply black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants