-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple streams and metadata parsing to 'ffmpeg_parse_infos' #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mondeja
added
enhancement
Positive change that does not change the API, i.e. improved performance, using less memory etc.
refactor
Does not affect the end user at all i.e. making code easier to read or PEP8 compliant.
performance
Speed/performance of code or individual functionality.
labels
Jan 18, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mondeja
changed the title
Add support for metadata parsing to 'ffmpeg_parse_infos'
Add support for multiple streams and metadata parsing to 'ffmpeg_parse_infos'
Jan 19, 2021
This comment has been minimized.
This comment has been minimized.
mondeja
force-pushed
the
ffmpeg_parse_infos-metadata
branch
from
January 20, 2021 12:49
59c4dfb
to
fd1f3bd
Compare
I think this implementation is stable enough now, so I go ahead with the merge... |
mondeja
removed
the
performance
Speed/performance of code or individual functionality.
label
Jan 21, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Positive change that does not change the API, i.e. improved performance, using less memory etc.
lib-FFmpeg
Issues pertaining to dependency FFmpeg.
refactor
Does not affect the end user at all i.e. making code easier to read or PEP8 compliant.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
video.io.ffmpeg_reader.ffmpeg_parse_infos
function.video.io.ffmpeg_reader.ffmpeg_parse_infos
function (first step to fix in the future multiple input audio streams not getting merged #178).video.io.ffmpeg_reader.ffmpeg_parse_infos
function.-hide_banner
option to ffmpeg command inffmpeg_parse_infos
to remove the ffmpeg banner for better performance.Increased parsing speed ofAfter chapters parsing added, the speed of both implementations is the same.ffmpeg_parse_infos
, all the parsing is done in a single loop."video_rotation"
field returned byffmpeg_parse_infos
is placed now at["video_metadata"]["rotate"]
.test_ffmpeg_parse_infos_for_i926
because the same behaviour is checked in another test.tests/
black -t py36