Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap 'creationflags=0x08000000' Popen kwarg in function #1470

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Wrap 'creationflags=0x08000000' Popen kwarg in function #1470

merged 1 commit into from
Jan 19, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 19, 2021

This avoid repetition of same Windows check before all subprocess.Popen calls.

@mondeja mondeja added the refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. label Jan 19, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 66.053% when pulling 017c7aa on mondeja:crossplatform-popen-params into ce7b129 on Zulko:master.

@mondeja mondeja merged commit 22e207e into Zulko:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tburrows13 tburrows13 tburrows13 approved these changes

Assignees
No one assigned
Labels
refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mondeja @coveralls @tburrows13