Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test some ffmpeg video tools and document them #1587

Merged
merged 2 commits into from
May 25, 2021
Merged

Test some ffmpeg video tools and document them #1587

merged 2 commits into from
May 25, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented May 25, 2021

  • Add missing logger argument to ffmpeg_stabilize_video.
  • Allow to pass start_time and end_time arguments of ffmpeg_extract_subclip as time formats (AA:BB:CC, tuples...).
  • Document ffmpeg tools.
  • Test some of the ffmpeg tools.
  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

@mondeja mondeja added documentation Related to documentation in official project docs or individual docstrings. tests Related to individual tests in the test suite or running the test suite. video Related to VideoClip and related classes, or handling of video in general. lib-FFmpeg Issues pertaining to dependency FFmpeg. and removed video Related to VideoClip and related classes, or handling of video in general. labels May 25, 2021
@coveralls
Copy link

coveralls commented May 25, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 73.036% when pulling 498efa6 on mondeja:ffmpeg-tools-tests into 6e4d083 on Zulko:master.

@mondeja mondeja force-pushed the ffmpeg-tools-tests branch from 4d8e2b2 to 498efa6 Compare May 25, 2021 10:19
@mondeja mondeja merged commit e6764f5 into Zulko:master May 25, 2021
@mondeja mondeja deleted the ffmpeg-tools-tests branch May 25, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Related to documentation in official project docs or individual docstrings. lib-FFmpeg Issues pertaining to dependency FFmpeg. tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mondeja @coveralls