Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Clip class and improve its documentation #1589

Merged
merged 4 commits into from
May 26, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented May 26, 2021

  • Add missing tests for Clip class.
  • Improve Clip methods documentation.
  • If start_time >= clip.duration in Clip.subclip method, raise ValueError (previously raised only if start_time > clip.duration).
  • If end_time < 0 and clip.duration is None in Clip.subclip method, raise ValueError instead of printing a message to stdout.
  • Raise ValueError instead of Exception in Clip.with_duration method.
  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

@mondeja mondeja added documentation Related to documentation in official project docs or individual docstrings. tests Related to individual tests in the test suite or running the test suite. labels May 26, 2021
@coveralls
Copy link

coveralls commented May 26, 2021

Coverage Status

Coverage increased (+0.8%) to 75.23% when pulling 2fd4190 on mondeja:Clip-tests into d213793 on Zulko:master.

@mondeja mondeja merged commit 0bdc91c into Zulko:master May 26, 2021
@mondeja mondeja deleted the Clip-tests branch May 26, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation in official project docs or individual docstrings. tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants