Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for 'download_webfile' #1595

Merged
merged 4 commits into from
May 27, 2021
Merged

Add tests for 'download_webfile' #1595

merged 4 commits into from
May 27, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented May 27, 2021 •
edited
Loading

  • Add tests for download_webfile function.
  • Document it correctly.
  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

@mondeja mondeja added documentation Related to documentation in official project docs or individual docstrings. tests Related to individual tests in the test suite or running the test suite. labels May 27, 2021
@coveralls
Copy link

coveralls commented May 27, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 78.192% when pulling d3affed on mondeja:downloader-tests into b82c9d6 on Zulko:master.

@mondeja mondeja changed the title Add tests for 'download_website' Add tests for 'download_webfile' May 27, 2021
@mondeja mondeja merged commit c9c781b into Zulko:master May 27, 2021
@mondeja mondeja deleted the downloader-tests branch May 27, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Related to documentation in official project docs or individual docstrings. tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mondeja @coveralls