Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests and documentation for FramesMatches #1600

Merged
merged 4 commits into from
May 31, 2021
Merged

Add more tests and documentation for FramesMatches #1600

merged 4 commits into from
May 31, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented May 31, 2021 •
edited
Loading

  • Add tests for FramesMatches class.
  • Add documentation for some FramesMatches methods.
  • Allow to pass optional arguments to clip.write_gif using FramesMatches.write_gifs.

Contributes to #1355

@mondeja mondeja added documentation Related to documentation in official project docs or individual docstrings. tests Related to individual tests in the test suite or running the test suite. labels May 31, 2021
@coveralls
Copy link

coveralls commented May 31, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 80.198% when pulling ab339e3 on mondeja:FramesMatches-select_scenes-tests into bfd3fb2 on Zulko:master.

@mondeja mondeja mentioned this pull request May 31, 2021
Closed
@mondeja mondeja merged commit 84582d9 into Zulko:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Related to documentation in official project docs or individual docstrings. tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mondeja @coveralls