Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to prevent decorators arguments inconsistency #1610

Merged
merged 4 commits into from
Jun 2, 2021
Merged

Add tests to prevent decorators arguments inconsistency #1610

merged 4 commits into from
Jun 2, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jun 2, 2021 •
edited
Loading

  • Add two tests for decorators @convert_parameter_to_seconds and @convert_path_to_string, which check that the decorator call definition's arguments match with the wrapped function definition's arguments. Prevents Fix HH:MM:SS format support for 'Clip.with_duration' #1609 from happening again.
  • Fix undefined exposed function using from moviepy.audio.fx import *.

@mondeja mondeja added the tests Related to individual tests in the test suite or running the test suite. label Jun 2, 2021
@coveralls
Copy link

coveralls commented Jun 2, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.6%) to 84.997% when pulling b13cb42 on mondeja:decorators-arguments-consistency into 3dc3b4f on Zulko:master.

@mondeja mondeja merged commit 215cab6 into Zulko:master Jun 2, 2021
@mondeja mondeja deleted the decorators-arguments-consistency branch June 2, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mondeja @coveralls