Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MKV support allowing h264 w/ alt. sound codecs #1657

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Add MKV support allowing h264 w/ alt. sound codecs #1657

merged 1 commit into from
Nov 10, 2021

Conversation

abramhindle
Copy link
Contributor

@abramhindle abramhindle commented Sep 8, 2021 •
edited
Loading

Added 1 line for moviepy to be able to use FFMPEG to make matroska mkv files that can handle a variety of sound codecs as well has h264 video codecs. It has allowed me to output a mkv with h264 video and pcm_s16le audio :-)

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

@abramhindle
Add MKV support allowing h264 w/ alt. sound codecs
cb412bf 
Added 1 line for moviepy to be able to use FFMPEG to make matroska mkv files that can handle a variety of sound codecs as well has h264 video codecs. It has allowed me to output a mkv with h264 video and pcm_s16le audio :-)
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 84.501% when pulling cb412bf on abramhindle:patch-1 into 576fb1a on Zulko:master.

@mondeja mondeja added enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc. lib-FFmpeg Issues pertaining to dependency FFmpeg. labels Oct 3, 2021
mondeja
mondeja approved these changes Nov 10, 2021
View reviewed changes
Copy link
Collaborator

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mondeja mondeja merged commit 662b26e into Zulko:master Nov 10, 2021
zpavloudis pushed a commit to zpavloudis/moviepy that referenced this pull request May 22, 2022
@abramhindle @zpavloudis
Add MKV support allowing h264 w/ alt. sound codecs (Zulko#1657)
575aa6b 
Added 1 line for moviepy to be able to use FFMPEG to make matroska mkv files that can handle a variety of sound codecs as well has h264 video codecs. It has allowed me to output a mkv with h264 video and pcm_s16le audio :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mondeja mondeja mondeja approved these changes

Assignees
No one assigned
Labels
enhancement Positive change that does not change the API, i.e. improved performance, using less memory etc. lib-FFmpeg Issues pertaining to dependency FFmpeg.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abramhindle @coveralls @mondeja