Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated reference in docstring (#1688) #1744

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

ezioruan
Copy link
Contributor

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

@keikoro keikoro linked an issue Apr 3, 2022 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Apr 3, 2022

Coverage Status

Coverage remained the same at 84.789% when pulling 8d56979 on ezioruan:fix_1688 into 5853ff8 on Zulko:master.

@keikoro
Copy link
Collaborator

keikoro commented May 11, 2022

@ezioruan Letting you know we've updated our CI settings. If you could update your PR to incorporate the latest changes to the code base – rebase master, (force) push the branch you used to open this PR – that'd be great.

@ezioruan
Copy link
Contributor Author

@ezioruan Letting you know we've updated our CI settings. If you could update your PR to incorporate the latest changes to the code base – rebase master, (force) push the branch you used to open this PR – that'd be great.
sure. Done

Copy link
Collaborator

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mondeja mondeja merged commit 025c3fe into Zulko:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outdated reference in docstring
4 participants