Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix audio processing for streams with missing audio_bitrate #1783

Merged
merged 3 commits into from
Jun 1, 2022
Merged

Fix audio processing for streams with missing audio_bitrate #1783

merged 3 commits into from
Jun 1, 2022
+21 −1

Conversation

B3QL
Copy link
Contributor

@B3QL B3QL commented Jun 1, 2022

Set default audio_bitrate to None.

Similar to #1781 if the file is footage from Hikvision CCTV the bitrate is not available to read even if the audio stream is present.

Sample.mp4
  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

@B3QL B3QL changed the title Set default audio_bitrate Fix audio processing for streams with missing audio_bitrate Jun 1, 2022
@B3QL
Copy link
Contributor Author

B3QL commented Jun 1, 2022

@mondeja can you take a look? thanks!

@coveralls
Copy link

coveralls commented Jun 1, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 84.87% when pulling 9a79d75 on TraseeHQ:b/hikvision-missing-audio-bitrate into df84762 on Zulko:master.

@B3QL B3QL requested a review from mondeja June 1, 2022 11:16
mondeja
mondeja approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@mondeja mondeja merged commit 18e9f57 into Zulko:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mondeja mondeja mondeja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@B3QL @coveralls @mondeja