Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix textclip filename parameter in wrong format #1788

Merged
merged 4 commits into from
Oct 10, 2022
Merged

Fix textclip filename parameter in wrong format #1788

merged 4 commits into from
Oct 10, 2022

Conversation

MohamedAbdultawab
Copy link
Contributor

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

closes #1787

@MohamedAbdultawab
test: add test to uncover textclip filename parameter bug
068a7f1 
Regardless you provide a filename or text paramter,
the final text attribute should be of the format @<file_name>
not @%<file_name> which is how it's set before this fix.
@MohamedAbdultawab
fix: remove unused string formattin % in TextClip init with filename
0eb9a4f 
Regardless you provide a filename or text paramter,
the final text attribute should be of the format @<file_name>
not @%<file_name> which is how it's set before this fix.
@coveralls
Copy link

coveralls commented Jun 4, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 84.525% when pulling dff0889 on MohamedAbdultawab:fix_textclip_filename_parameter_in_wrong_format into 18e9f57 on Zulko:master.

@keikoro keikoro requested a review from mondeja June 30, 2022 22:49
@mondeja mondeja removed their request for review July 1, 2022 09:12
@mondeja mondeja added bug-fix For PRs and issues solving bugs. lib-ImageMagick Issues pertaining to dependency ImageMagick. labels Oct 10, 2022
@mondeja mondeja merged commit 97870c9 into Zulko:master Oct 10, 2022
@keikoro keikoro added hacktoberfest-accepted For Hacktoberfest PRs. See https://hacktoberfest.digitalocean.com/faq and removed hacktoberfest-accepted For Hacktoberfest PRs. See https://hacktoberfest.digitalocean.com/faq labels Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix For PRs and issues solving bugs. lib-ImageMagick Issues pertaining to dependency ImageMagick.
Projects
None yet
Milestone
No milestone
4 participants
@MohamedAbdultawab @coveralls @keikoro @mondeja