Fix GitHub workflow badge #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the linked GitHub issue from the previous version of the badge: badges/shields#8671 In summary, this badge was changed in a breaking fashion such that the badge was just linking to the github issue rather than showing the data. Updating the url resolves this. I also updated the link for the badge, so it matches the behaviour of the badge more closely (matching on the workflow file, rather than the name).
|
Thank you, @EFord36! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build badge is currently broken:
This PR fixes it, so it looks like:
In summary, this badge was changed in a breaking fashion such that the badge was just linking to the github issue rather than showing the data. Updating the url resolves this.
See the linked GitHub issue from the previous version of the badge for further details: badges/shields#8671
I also updated the link for the badge, so it matches the behaviour of the badge more closely (matching on the workflow file, rather than the name).
I don't think any of the PR template check boxes applies, since this is a doc-only change - but hopefully the screenshots above are evidence of the 'fix'.