-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take into account rotation metadata to define video size #577
Conversation
- ffmpeg autorotates videos but the video_size is unhanged, this results e.g. in stretched output images or even unreadable images or videos. This commit exchanges width and height if 90 or 270 degree rotation was detected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, Is there anyway to add a unit test, or show that it works?
I'm planning to do a short test. Sorry for not replying earlier. But it can take some time. It's on my list. |
Linking #683 |
It seems to me that this is the right fix, but needs rewriting for the new ffmpeg output parser and a proper test case, maybe using this video or better creating multiples ones with ffmpeg at runtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just merged it with master, added two tests and changed the place where the fix is being applied. I prefer just change the size in the FFMPEG_VideoReader
instance so parsing ffmpeg -i
output the metadata fits as much ffmpeg output as possible.
4 years later but this is merged now 👍 In the future this could be improved defining optionally the rotation metadata writing files accordingly, (some |
This was merged last year, but it has been almost 2 years since a new version was released. Could you release this? |
Please release this |
Could you release this? |
this results e.g. in stretched output images or even unreadable images or videos.
This commit exchanges width and height if 90 or 270 degree rotation was detected.