Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize Video - New functionality #580

Merged
merged 19 commits into from
May 6, 2020
Merged

Conversation

gpantelis
Copy link
Contributor

New method that stabilaze a video

@coveralls
Copy link

coveralls commented Jun 4, 2017

Coverage Status

Coverage decreased (-0.08%) to 54.003% when pulling 40a2d96 on gpantelis:patch-5 into 1c5c633 on Zulko:master.

@Zulko
Copy link
Owner

Zulko commented Jun 5, 2017

Thanks for this, seems very useful, can you change stabilaze->stabilize and make the code PEP8 compatible (4-spaces indent, one space after commas) ?

@coveralls
Copy link

coveralls commented Jun 5, 2017

Coverage Status

Coverage decreased (-0.08%) to 54.003% when pulling c313fdb on gpantelis:patch-5 into 1c5c633 on Zulko:master.

moviepy/video/io/ffmpeg_tools.py Outdated Show resolved Hide resolved
moviepy/video/io/ffmpeg_tools.py Outdated Show resolved Hide resolved
moviepy/video/io/ffmpeg_tools.py Show resolved Hide resolved
moviepy/video/io/ffmpeg_tools.py Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 5, 2017

Coverage Status

Coverage decreased (-0.08%) to 54.003% when pulling b049529 on gpantelis:patch-5 into 1c5c633 on Zulko:master.

@coveralls
Copy link

coveralls commented Jun 5, 2017

Coverage Status

Coverage decreased (-0.08%) to 54.003% when pulling 3bd0075 on gpantelis:patch-5 into 1c5c633 on Zulko:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 53.172% when pulling 2dbdf1d on gpantelis:patch-5 into 1c5c633 on Zulko:master.

2 similar comments
@coveralls
Copy link

coveralls commented Jun 5, 2017

Coverage Status

Coverage decreased (-0.9%) to 53.172% when pulling 2dbdf1d on gpantelis:patch-5 into 1c5c633 on Zulko:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 53.172% when pulling 2dbdf1d on gpantelis:patch-5 into 1c5c633 on Zulko:master.

@gpantelis
Copy link
Contributor Author

What im doing wrong?

@coveralls
Copy link

coveralls commented Jun 5, 2017

Coverage Status

Coverage increased (+0.1%) to 65.14% when pulling d54046e on gpantelis:patch-5 into 24ebfdb on Zulko:master.

@tburrows13 tburrows13 added the feature New addition to the API i.e. a new class, method or parameter. label Jun 6, 2017
@mbeacom mbeacom changed the title New functionality Stabilize Video - New functionality Jun 6, 2017
@tburrows13
Copy link
Collaborator

I think we should have a test for this in /tests. Also, I'd be interested to see a before and after video (or 2 separate videos) of this PR being used.

@gpantelis
Copy link
Contributor Author

Okay I'm working on it!

@mbeacom mbeacom added the tests-needed PRs/code submissions which need test cases added to them. label Jun 7, 2017
@ghost
Copy link

ghost commented Jun 14, 2017

@gpantelis

here is some code that could help you...


ffmpeg_stabilized_video("deshake_test.mp4", output="deshake_output.mp4")

video=VideoFileClip("deshake_test.mp4")
video1=VideoFileClip("deshake_output.mp4")
video.size=(video.w/2, video.h)
video1.size=(video1.w/2, video1.h)

video=clips_array([[video, video1]])
video.write_videofile("deshake.mp4")

@gpantelis
Copy link
Contributor Author

Nice thanks!

@mbeacom mbeacom added this to the Release v0.2.3.3 milestone Jun 15, 2017
@kencochrane
Copy link
Contributor

@gpantelis thanks for the PR, just curious if you had a chance to work on the unit tests yet? Need any help?

@tburrows13
Copy link
Collaborator

I'm ready for this to be merged.

@tburrows13 tburrows13 removed the tests-needed PRs/code submissions which need test cases added to them. label Apr 24, 2020
@tburrows13 tburrows13 merged commit 203f347 into Zulko:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New addition to the API i.e. a new class, method or parameter.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants