Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use popen.communicate() to prevent subprocess hang #684

Merged
merged 3 commits into from
Jun 3, 2020
Merged

Use popen.communicate() to prevent subprocess hang #684

merged 3 commits into from
Jun 3, 2020

Conversation

tehKost
Copy link
Contributor

@tehKost tehKost commented Dec 12, 2017

Broken video files caused ffmpeg subprocess to hang

Broken video files caused ffmpeg subprocess to hang
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 56.962% when pulling a5c4823 on tehKost:master into f444f8c on Zulko:master.

@coveralls
Copy link

coveralls commented Dec 12, 2017

Coverage Status

Coverage increased (+0.01%) to 67.459% when pulling 29c53d7 on tehKost:master into a1df46d on Zulko:master.

@tburrows13 tburrows13 added the bug-fix For PRs and issues solving bugs. label Dec 19, 2017
@mgaitan
Copy link
Collaborator

mgaitan commented Apr 16, 2018

could we merge this?

@tburrows13
Copy link
Collaborator

It looks like this has already mostly been implemented elsewhere, however without the terminate().

@tburrows13
Copy link
Collaborator

Largely superseded by #926, but I'm going to merge this change which now adds proc.terminate(). I doubt that it is necessary, but I don't think that it can hurt.

@tburrows13 tburrows13 merged commit c5da849 into Zulko:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix For PRs and issues solving bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants