Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

fixing error when event not sent #1110

Closed
wants to merge 3 commits into from

Conversation

barbararochazup
Copy link
Contributor

Signed-off-by: barbararochazup barbara.rocha@zup.com.br

Issue Description

When hermes is down event error can not be sent

Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
@boring-cyborg boring-cyborg bot added the moove Improvements/additions/fixes for moove module. label Apr 27, 2021
monicaribeiro
monicaribeiro previously approved these changes Apr 27, 2021
emiteze
emiteze previously approved these changes Apr 27, 2021
Signed-off-by: Mônica Ribeiro <monicarib1@gmail.com>
@monicaribeiro monicaribeiro dismissed stale reviews from emiteze and themself via c74277f April 27, 2021 16:40
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #1110 (58c3295) into main (8d60e46) will increase coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1110      +/-   ##
============================================
+ Coverage     77.30%   77.61%   +0.30%     
- Complexity     1978     2172     +194     
============================================
  Files          1223     1254      +31     
  Lines         16969    17535     +566     
  Branches       1580     1602      +22     
============================================
+ Hits          13118    13609     +491     
- Misses         3373     3442      +69     
- Partials        478      484       +6     
Flag Coverage Δ Complexity Δ
moove 75.26% <100.00%> (+1.19%) 1653.00 <1.00> (+194.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...charlescd/moove/application/WebhookEventService.kt 100.00% <100.00%> (ø) 26.00 <1.00> (?)
...oove/legacy/moove/api/response/UndeployResponse.kt 0.00% <0.00%> (-50.00%) 0.00% <0.00%> (-1.00%)
...e/configuration/SimpleFeignEncoderConfiguration.kt 40.00% <0.00%> (-34.08%) 2.00% <0.00%> (ø%)
...ve/legacy/moove/controller/DeploymentController.kt 0.00% <0.00%> (-33.34%) 0.00% <0.00%> (-2.00%)
...rlescd/moove/application/CsvSegmentationService.kt 67.18% <0.00%> (-17.19%) 16.00% <0.00%> (-4.00%)
...in/io/charlescd/moove/application/CircleService.kt 84.84% <0.00%> (-15.16%) 11.00% <0.00%> (+3.00%) ⬇️
...pplication/workspace/response/WorkspaceResponse.kt 86.84% <0.00%> (-11.28%) 10.00% <0.00%> (ø%)
...cd/moove/application/user/response/UserResponse.kt 95.23% <0.00%> (-4.77%) 7.00% <0.00%> (-1.00%)
...ation/module/impl/UpdateComponentInteractorImpl.kt 90.00% <0.00%> (-3.34%) 7.00% <0.00%> (+2.00%) ⬇️
...tion/workspace/impl/FindWorkspaceInteractorImpl.kt 87.80% <0.00%> (-1.67%) 6.00% <0.00%> (+2.00%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be072db...58c3295. Read the comment docs.

Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
@barbararochazup barbararochazup deleted the hotfix/webhook-sent-error branch April 27, 2021 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants