This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
refactoring last status health check endpoint #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
Codecov Report
@@ Coverage Diff @@
## feature/weebhook #929 +/- ##
======================================================
+ Coverage 69.25% 69.48% +0.23%
- Complexity 1736 1741 +5
======================================================
Files 1196 1198 +2
Lines 17068 17300 +232
Branches 1570 1605 +35
======================================================
+ Hits 11820 12021 +201
- Misses 4760 4794 +34
+ Partials 488 485 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
pedroborgeszup
suggested changes
Feb 23, 2021
| query := main.db.Model(&MessagesExecutionsHistory{}).Where("execution_id = ?", executionId).Order("logged_at desc").Find(&response).Limit(1) | ||
| if query.Error != nil { | ||
| return payloads.FullMessageExecutionResponse{}, errors.NewError("FindLastByExecution History error", query.Error.Error()). | ||
| WithOperations("FindLastByExecution.Result") |
There was a problem hiding this comment.
FindLastByExecution -> FindLastByExecutionId
Signed-off-by: barbararochazup <barbara.rocha@zup.com.br>
…ZupIT/charlescd into bugfix/subscription-helth-check
pedroborgeszup
approved these changes
Feb 23, 2021
pedroborgeszup
approved these changes
Feb 23, 2021
ifdouglas
changed the title
washingtonsoares
approved these changes
Feb 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: barbararochazup barbara.rocha@zup.com.br